On Thu, Aug 25, 2016 at 7:52 PM, Vincent Massol <[email protected]> wrote:
> > > On 25 Aug 2016, at 18:36, Vincent Massol <[email protected]> wrote: > > > > Hi devs, > > > > Marius has recently introduced the honoring of text editor for xproperty > editing for textarea types. > > > > This is great but it’s causing a lot of backward compatibility issues. > We’ve fixed several xclass to use “puretext” for code but there are plenty > out there still. > > > > I’ve just found another one with XWiki.WatchListMessage. > > > > The issue is that this is a blocker. I was trying to make a change there > so I was editing using the “source” mode of CKEditor. The problem is that > when I saved there were a lot of changes made to the content automatically, > breaking the code, see for example: > > https://www.evernote.com/l/AHf4KpfVtfBOK5zqcyf_up1Rty923fZOm-I > > > > The main issue is that I’m stuck. There’s nothing I can do in my wiki > (without resorting to scripting, using REST, etc). > > > This is not true; I can go to the XWiki.Mail page and edit the xclass and > change the editor to use. That’s still complex and requires knowledge. > Or you can change your preferred editor from "WYSIWYG" to "Text". Either from the user profile, "Default editor to use", or from the Administration > Edit Mode Settings, "Default Editor". If you're accessing the Object or Class edit modes then you are an advanced user (as specified by the user preferences) and most probably you prefer a plain text editor rather than a visual editor. The default Admin user should probably be configured to use the Text editor and not WYSIWYG. That doesn't mean we shouldn't fix the value of the Editor meta property for the existing xproperties by setting the right editor (not by leaving it empty), but it's not as critical as you suggest. Using PureText when the editor is not set for an xproperty is possible ( https://github.com/xwiki/xwiki-platform/blob/xwiki-platform-8.3-milestone-1/xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/TextAreaClass.java#L159 ) but it means there is no fallback on the user preferences and the administration, which some users might complain about. Thanks, Marius > Thanks > -Vincent > > > > > I’m proposing that we do the opposite: > > * When no editor is specified, use the wiki editor. Apps that want > WYSIWYG in xproperties should say so. > > > > This is actually more logical to me because the object editor is a > technical editor. > > > > In any case we need a solution that doesn’t break backward compatiblity. > > > > Since this change of behavior (honoring the editor for xproperties in > the object editor) was introduced in XWiki 8.2 we need to act fast before > it becomes a problem for our users. > > > > WDYT? > > > > Thanks > > -Vincent > > > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
