Hello Clemens, all

On Mon, Sep 5, 2016 at 1:24 PM, Vincent Massol <[email protected]> wrote:

> Hi Clemens,
>
> > On 03 Sep 2016, at 22:04, Clemens Klein-Robbenhaar <
> [email protected]> wrote:
> >
> > Hi Devs,
> >
> > if nobody objects I would like to cut a new release for the Publication
> Workflow Application
> > at http://extensions.xwiki.org/xwiki/bin/view/Extension/
> XWiki+Publication+Workflow+Application
> >
> > The version number would be 1.7
> >
> > I would like to make the release on Tuesday (unless Monday is a bank
> holiday or the like, in case of the release date shifts to Wednesday)
> >
> > The release would fixes the following issues:
> >
> > http://jira.xwiki.org/browse/XAWORKFLOW/fixforversion/16658
> >
> > The main change would be some basic support for multi-language
> documents, which I know someone would really appreciate.
> >
> > There are two new translation keys:
> >
> > one is introduced for XAWORKFLOW-27 and is shown in the workflow panel
> as a hint
> > for the publisher who is publishing a multi-language document, informing
> about the fact that all language variants are going to be published
> >
> > workflow.panel.publish.hintLanguages
> >
> > and one that showed up as missing while checking XAWORKFLOW-28:
> >
> > PublicationWorkflow.PublicationWorkflowConfigClass_groupedit_hint =
> Edit Workflow Group
> >
> > Unfortunately the default "Translations" document is in French, and as I
> did not want to show in translation key for unsupported languages, I just
> filled in an English text.
> > If someone could replace these "dummy translations" with a proper French
> text this would be really appreciated.
> >
> >
> > Are there any objections to the release? Does someone want more time to
> look at the changes?
>
> This looks good to me. FYI I’ve pinged Anca who’s the creator of this
> extension AFAIK.
>

I looked really quickly at the code and I made two comments on the commits
in question. I am not against the release, but I would feel more
comfortable if we addressed these two commits.

But then again, if you're in a hurry, you can release 1.7 like this (which
risks to have some issues) and then fix the subjects addressed in these
comments in subsequent 1.7.x .

Anca


>
> > Cheers
> > Clemens
> >
> > P.S. if there are no objections I can handle most parts of the release
> on my own, but need a bit of help with updating the versions in JIRA.
>
> Sure, I can help if need be.
>
> Thanks
> -Vincent
>
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
>
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to