On Tue, Sep 13, 2016 at 7:37 PM, Vincent Massol <[email protected]> wrote:
> > > On 13 Sep 2016, at 18:24, Vincent Massol <[email protected]> wrote: > > > > Hi Edy, > > > >> On 13 Sep 2016, at 18:03, Eduard Moraru <[email protected]> wrote: > >> > >> Hi, > >> > >> Let`s think about active installs. The client module (i.e. the one doing > >> the work and reporting) can be considered core, but the server module > (the > >> one receiving and showing a UI of the collected data) is not really core > >> and can be moved to contrib. This will also fix the chart macro issue, > >> since it's the server/ui module depending on it and not the client-api > one. > > > > Indeed you’re completely right! Don’t know why I didn’t think about this > :) > > Now that said, we might want to have other core stuff use the chart macro > in the future. > > Are we really sure we’ll never want to use the chart macro in any core UI? > Are we really sure that this strategy is realistic? I mean, if one core module needs at some point, for some remote feature, to depend on the chart macro, does that automatically make the chart macro core? IMO no, otherwise we end up saying that all dependencies of core modules are core as well (could even argue the need to control the sources of all those dependencies as well), which would be obviously bad. This question probably leads back to the definition of core and what it implies. Thanks, Eduard > > Thanks > -Vincent > > > Thanks > > -Vincent > > > >> Thanks, > >> Eduard > >> > >> On Sun, Sep 11, 2016 at 8:45 PM, Vincent Massol <[email protected]> > wrote: > >> > >>> > >>>> On 11 Sep 2016, at 19:24, Vincent Massol <[email protected]> wrote: > >>>> > >>>> Hi devs, > >>>> > >>>> I’d like to propose: > >>>> * move out the Chart Macro + Renderer to Contrib since it’s not core. > >>>> * still depend on it in the XE distribution for now. However if > everyone > >>> feels that it’s not needed to have it by default for users and that > it’s > >>> better to let them install it, I’m also fine. But right now I prefer to > >>> have it by default. > >>>> > >>>> WDYT? > >>> > >>> hmm there’s a small problem… Right now the Active Installs module uses > the > >>> chart macro… > >>> > >>> And Statistics UI too. I guess this one could be moved to contrib > easily > >>> (we don’t bundle it anymore by defaultà. > >>> > >>> However for ActiveInstalls it’s more complex, unless we don’t want to > >>> consider it core but I don’t think we want that… > >>> > >>> So it means either we stop using the chart macro there (which would be > a > >>> shame) or we consider the chart macro core… > >>> > >>> Any idea? > >>> > >>> Thanks > >>> -Vincent > >>> > >>>> Thanks > >>>> -Vincent > > > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
