On Fri, Sep 23, 2016 at 11:55 AM, Manuel Smeria <[email protected]> wrote:
> Hello Devs, > > I would like to propose a new best practice for the way we close issues as > Duplicate. > > As an example I've reported this issue: > http://jira.xwiki.org/browse/XWIKI-13728 which was later closed as a > Duplicate to http://jira.xwiki.org/browse/XWIKI-13729. > > From my perspective, this is not correct since the issue I reported is > valid from an user's POV. > I would have preferred that my issue was renamed and that developers would > have added some technical information as a comment to it if they wanted to > do so. > It just doesn't make any sense to me to close a perfectly valid issue as a > Duplicate just to create another one that has a more technically correct > summary and description. > > It also doesn't make sense to close the original issue as a Duplicate to a > duplicate issue :) (pun intended) > Said differently: Does it make sense to close the "cause" as a duplicate of one specific "manifestation" (e.g. occurring in application A), and all the other various manifestations (in applications B, C or D) as duplicate of that particular "manifestation" (from application A), just because it was reported in application A first? I would say no. I see things like this: my issue's description is a use-case of the issue > later reported by Edy, so if anything, Edy's issue should be closed as a > Duplicate to mine and not the other way around. > > One scenario where I think issues dated previously should be closed as > Duplicate is if the new issue has already been fixed. For example when a > Developer doesn't notice an older issue and starts working on the new one > instead of closing the new one as a Duplicate and work on the older one. > There might be more, feel free to add them to this thread. > > So, what I propose is that we don't close original issues as Duplicate > unless it falls into the category previously described or some other > exceptions that I can't think of now and might occur. > > Thanks, > Manuel > Another thing worth mentioning is that in this particular case that you`ve mentioned, I`ve created the issue because I was not able to handle it on the spot and I considered the problem to be of enough importance to deserve its own issue (and thus gather visibility). In practice, when the dev addresses the reported manifestation on the spot, the fix can easily be committed directly on the manifestation issue itself, without needing to create a separate "cause" issue. We don`t really have a practice to handle things this way (i.e. always create a "cause" issue), probably also to avoid artificially increasing the number of issues and also to keep formalities low. However, if we do end up having the cause issue (which in this case we do, due to the reason I mentioned), I would see it more reasonable to mark the manifestation as the duplicate of the cause. Thanks, Eduard _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
