2016-10-10 17:29 GMT+02:00 Vincent Massol <vinc...@massol.net>:
> Hi Guillaume,
> > On 10 Oct 2016, at 16:43, Guillaume Delhumeau <
> guillaume.delhum...@xwiki.com> wrote:
> > Hello.
> > In Flamingo, we have a variable called $displayPageHeader, defined in
> > layoutvars.vm.
> > When it is set, the logo is not displayed in the top menu, but on a
> > under it. It is used by some clients, where they could also add some
> > content.
> hmmm… I’m wondering if this is the best way.
> We already a UIXP for page header so if some users want a custom header
> they can already do so. I don’t think it belongs to the theme.
Indeed, adding content by modifying the header is not the best way.
Anyway, I think it is still useful to have this option. In the header, the
user have the ability to display a bigger logo for example, and a
background corresponding to its visual identity. And it's easier than
creating a UIX for this.
Since Caty has created the issue http://jira.xwiki.org/browse/XWIKI-13160,
maybe she has some example to show us.
> So instead I would have a boolean to decide whether to display the logo or
> not. Actually even that boolean could be avoided by deciding that if the
> logo field is empty then no logo is displayed.
When no logo is chosen, the current behavior is to fallback to the XWiki
> Am I missing something?
For your information, the code I was working on is here:
and ready to be merged.
> > Example:
> > http://tof.canardpc.com/view/83040d2d-79c4-4f1b-ab1b-af8ee5f3be62.jpg
> > I'd like to expose this variable into the Flamingo Theme, see:
> > http://jira.xwiki.org/secure/attachment/33074/33074_preview.png
> > However, in order to enable the live preview in the theme editor, I need
> > be able to change the value of the $displayPageHeader variable on the
> > or at least by setting a parameter in the query string.
> > This variable will be:
> > displayPageHeader
> > Possible values:
> > "true", "false"
> > Default value:
> > Fallback to the Flamingo Theme, "false" if empty.
> > I don't have other use-case to cover with this variable.
> > Here is my +1.
> > Thanks,
> > --
> > Guillaume Delhumeau (guillaume.delhum...@xwiki.com)
> devs mailing list
Guillaume Delhumeau (guillaume.delhum...@xwiki.com)
Research & Development Engineer at XWiki SAS
Committer on the XWiki.org project
devs mailing list