> On 12 May 2017, at 09:45, Vincent Massol <vinc...@massol.net> wrote: > > Hi Clement, > >> On 12 May 2017, at 09:40, Clément Aubin <clement.au...@xwiki.com> wrote: >> >> Hello ! >> >> On 05/09/2017 06:42 PM, Vincent Massol wrote: >>> Ok I’ve implemented it today. >>> >>> I’ve also updated http://dev.xwiki.org/xwiki/bin/view/Community/Chat >>> >>> Thanks >>> -Vincent >> >> It seems that now, the history of the #xwiki IRC channel isn’t logged >> anymore (see : >> http://dev.xwiki.org/xwiki/bin/view/IRC/#|t=ircarchives&p=1&l=10&s=doc.creationDate&d=desc). > > You’re absolutely right… that’s an issue I had forgotten about :( > > I’ve moved the bot to xwiki-notifications but by doing so I’ve also moved the > log archiving since it was done by that bot. > > So this means some work to make this possible. I’ll need to look at the Bot > code to see what’s the simplest for this (either allow the ircbot app to > connect to several channels or allow the ircbot app to be installed in > different spaces and run 2 bots).
I’ve been looking at the ircbot app code and I think what needs to be done is the following: * Make it support several bots instead of one. Instead of "@Inject private IRCBot bot”, use “@Inject private MultiBotManager multiBotManager” + change APIs * Allow having several Bot config xobjects (one per bot) on the ircbot config page (ie. IRC.IRCConfiguration) * Internally use the PircBotX MultiBotManager (http://thelq.github.io/pircbotx/latest/apidocs/org/pircbotx/MultiBotManager.html) * Add a new config data for IRCBotListener which corresponds to the ids of the Bots for which the listener must be active. So both on the Java side and for the IRC.IRCBotListenerClas xclass. * For the moment start/stop all bots together. This is not trivial (probably requires 1 day of work total) but I don’t see any other option right now if we wish to continue to split the bot into 2. Unless someone has a better idea, I’ll try to go for this in the coming days. Thanks -Vincent > Thanks for raising this problem! > -Vincent > >> >> I know that the migration of the IRCBot from #xwiki to >> #xwiki-notifications should be made progressively (as said in >> http://xwiki.475771.n2.nabble.com/Proposal-Create-a-separate-IRC-channel-for-notifications-tp7603656.html), >> but we’re actually losing the history of our conversations on #xwiki. Is >> this really something we want? >> >> Thanks, >> >> -- >> Clément Aubin >> Web Developer Intern @XWiki SAS >> clement.au...@xwiki.com >> More about us at http://www.xwiki.com
