Hi DeSheng, > On 27 Jun 2017, at 07:10, deshengchuan <[email protected]> wrote: > > Hi all! > This is the third update regarding the progress of the Redpen integration > project. > Some of the info can also be accessed in the design page over here: > <http://design.xwiki.org/xwiki/bin/view/Proposal/RedPenIntegration> > > I have created a UI on XWiki. The two main parts are such: > First, the application homepage will allow users to key in possible spelling > and expression errors, and their recommended corrections. I have not started > on building the backend in Java to process this database yet, but I'll start > on it within the next couple of weeks. > Second, there is a setting page within the global administration wiki that > allows the user to key in basic settings parameters e.g. setting maximum > sentence length. > > The functionality is still restricted to validating a wiki page on document > save, but I will be implementing the function to run redpen validation as a > Job next, right after i finish fixing and stabilising some issues within the > code. > Any comments?
Thanks. I think you’re on the right track and that you understand well the objectives and what needs to be done :) Some questions/remarks: * I still need to review your code in the coming few days * Does it work? Am I able to get a RedPen validation when I save a page? (I need to test your extension now) * In the ConfigurableClass, you should use a static list of Strings that lets the user enter the exclusions so that they can enter regex. Something similar to http://extensions.xwiki.org/xwiki/bin/view/Extension/Multiselect%20custom%20display I think this would be more powerful. IMO you should also have includes and not just excludes to cover all use cases. * I see that you have implemented a UI to allow entering some words to be corrected. Does it mean that the RedPen execution not only validates content but is also able to modify it? Thanks for the update! -Vincent > -- > View this message in context: > http://xwiki.475771.n2.nabble.com/GSOC-Update-3-RedPen-Integration-tp7604255.html > Sent from the XWiki- Dev mailing list archive at Nabble.com.
