Hi Edy, +1 in general. Ideally, even though we should bundle it by default in our base flavor, it would be nice if it could be optional (i.e. if the blame API/UI modules are present in the WAR then clicking “view source” would display the blame view and if not, it would default to basic source viewing). Is that how you coded it? I’m saying “ideally” since it’s probably more work to do this (might even possibly require a UIX - or the whole source VM should be a UIX, I don’t know - BTW that might be cool to have automatic UIX based on template names to unify skins and UIX but that’s another topic ;)) and at this stage I’m already very happy that we’re getting this feature and you may not want to spend more time on it right now! :)
Nice work! Thanks -Vincent > On 1 Aug 2017, at 14:57, Eduard Moraru <[email protected]> wrote: > > Hi, devs, > > During a hackathon session, I have done a refresh on XWiki's code viewer > ("code.vm") and integrated the Blame API [1] developed by Denis to add > line-by-line blame information, just like GitHub's blame feature. > > Please see the associated Jira issue that also includes before and after > screenshots: > https://jira.xwiki.org/browse/XWIKI-14578 > > The Blame API module is a commons module since 2014 but not bundled neither > in the WAR nor in the flavor, so, in order to go along and merge my work, > I'd need it to be available as a core extension (to be also usable by > code.vm). > > I have not studied it deeply, but the module seems to be doing its job well > and the result is very nice and it is very generic. > > Being able to perform a blame analysis builds upon the diff module and both > are features of XWiki's versioning capabilities, so, IMO, both should be > considered core extensions (and not only the diff module, which already is > core). > > The PR is available at https://github.com/xwiki/xwiki-platform/pull/605 > > Here is my (obvious) +1 to bundle the blame-api and merge the PR which > includes the UI. > > Thanks, > Eduard > > ---------- > [1] http://extensions.xwiki.org/xwiki/bin/view/Extension/Blame%20Module
