Yes I had missed it. I wanted to implement it but first wanted to make sure we agreed before doing anything, hence this email.
I really disagree about using ONDEMAND as the default since it’s an important usability regression as it wouldn’t work OOB and the translations are not going to be applied and do anything useful. Thanks -Vincent > On 9 Feb 2018, at 19:42, Thomas Mortagne <thomas.morta...@xwiki.com> wrote: > > Looks like you missed https://jira.xwiki.org/browse/XWIKI-15013. > > IMO the safest is more ON DEMAND (which is a concept that does not > exist for macros). > > On Fri, Feb 9, 2018 at 6:15 PM, Vincent Massol <vinc...@massol.net> wrote: >> Hi, >> >> Right now we have: >> >> xclass.addStaticListField(TranslationDocumentModel.TRANSLATIONCLASS_PROP_SCOPE, >> "Scope", >> "GLOBAL|WIKI|USER|ON_DEMAND”); >> >> However for wiki macros for example we have: >> >> xclass.addStaticListField(MACRO_VISIBILITY_PROPERTY, "Macro visibility", 1, >> false, >> "Current User|Current Wiki|Global", ListClass.DISPLAYTYPE_SELECT, >> PROPERTY_PIPE); >> >> The rationale is that it’s safe to use USER first to try out and then to >> extend to Wiki or Global if it’s working fine. >> >> So I’d suggest to change the default visibility for wiki translations to >> USER and more generally to do this for all component-based xobjects. >> >> WDYT? >> >> Thanks >> -Vincent >> > > > > -- > Thomas Mortagne