Note that XS has the Menu Application installed only on the main wiki ATM. Also, the reason I used GLOBAL visibility for the Menu macro is because I wanted to support global menus (defined on the main wiki and visible everywhere). Installing the Menu Application both on the main wiki and on a subwiki can lead to unexpected results so I would not recommend it. The question is whether installing the Menu Application only on the subwiki is a valid use case or not.
We could also restrict the installation to the main wiki *only until* we add support for GLOBAL to WIKI visibility fallback for translations. +1 for this. Thanks, Marius On Tue, Aug 7, 2018 at 2:31 PM, Costi Listar <[email protected]> wrote: > While working on https://jira.xwiki.org/browse/XWIKI-14037, I noticed > that the Menu Macro has GLOBAL visibility. This implies that Menu > Translations should have GLOBAL visibility as well. But this will cause > issues if you install the Menu Application on a sub-wiki because there is > no fallback yet from GLOBAL visibility to WIKI in case of translations. > In order to avoid this problem, I propose to restrict the installation of > the Menu Application to the main wiki. > > I am +1 for this. > > Thanks, > Costi >
