> On 1 Oct 2018, at 10:18, Thomas Mortagne <thomas.morta...@xwiki.com> wrote:
>
> +1
>
> Now we should be careful about existing pages which are not in a Code
> space, moving them is often a breakage (and not just for xclass).
yes we should not move them. Not until we have a real solution such as aliases.
Thanks
-Vincent
> On Thu, Sep 27, 2018 at 4:04 PM Vincent Massol <vinc...@massol.net> wrote:
>>
>> Hi devs,
>>
>> I’ve just had a quick chat with Edy and I found that we had a difference of
>> opinion on the Code subspace practice.
>>
>> On
>> https://dev.xwiki.org/xwiki/bin/view/Community/ApplicationDevelopmentBestPractices
>> we say:
>> "Technical pages must be put in a subspace named Code”
>>
>> Now Edy says that this should be done only for data-generating apps.
>>
>> It’s not my recollection that this rule was only for this case and this is
>> what I’d like to discuss here.
>>
>> For example, I’ve noticed that ActiveInstalls has all technical pages under
>> ActiveInstalls, see
>> https://github.com/xwiki/xwiki-platform/tree/053f0a2757cea18a5916632a58c6046ba61954cd/xwiki-platform-core/xwiki-platform-activeinstalls/xwiki-platform-activeinstalls-server/xwiki-platform-activeinstalls-server-ui/src/main/resources/ActiveInstalls
>>
>> I would fix it to have only the WebHome remain under ActiveInstalls and move
>> all the technical pages under ActiveInstalls.Code.
>>
>> The only case where it could make sense to not have a Code subspace would be
>> when the app has no UI at all. Even in this case, you might argue that we
>> should always have a home to provide a description about the content of the
>> space.
>>
>> So right now I’m personally in favor of continuing the rule we defined in
>> the best practices:
>> "Technical pages must be put in a subspace named Code”
>>
>> WDYT?
>>
>> Thanks
>> -Vincent
>>
>
>
> --
> Thomas Mortagne
