Thanks Anca!
-Vincent
> On 18 Nov 2018, at 11:26, Anca Luca <lu...@xwiki.com> wrote:
>
> Hello all,
>
> as promised, the pull request is now merged (for 10.10-rc-1) and documented
> in the release notes for users.
>
> Anca
>
> On Sun, Oct 21, 2018 at 8:58 PM Anca Luca <lu...@xwiki.com> wrote:
>
>> Hello Vincent,
>>
>> done, I attached the same page exported with the previous export, for
>> comparison.
>>
>> On Sun, Oct 21, 2018 at 12:41 AM Vincent Massol <vinc...@massol.net>
>> wrote:
>>
>>> Hi Anca,
>>>
>>> Thanks for working on this.
>>>
>>> I wanted to quickly check it out so I went to the jira issue. What would
>>> have been nice would have been to have two 2 PDF exports (one before and
>>> one after), or simply 2 screenshots. Just to see visually what the changes
>>> you made are looking like. But if you don’t have the time for this, don’t
>>> worry, we can work with the text/PR. However, if you had some screenshots,
>>> it could go in the Release notes to show the improvements to the user.
>>>
>>> Thanks
>>> -Vincent
>>>
>>>> On 21 Oct 2018, at 01:50, Anca Luca <lu...@xwiki.com> wrote:
>>>>
>>>> Hello devs,
>>>>
>>>> I've whipped up quickly a couple of changes to the default PDF export of
>>>> the XWiki platform, to try to make it look a little nicer.
>>>> I created the issue here https://jira.xwiki.org/browse/XWIKI-15761 and
>>> the
>>>> pull request here https://github.com/xwiki/xwiki-platform/pull/900 .
>>>> I would like to merge that into master unless somebody has something
>>>> against it, so please speak up now.
>>>>
>>>> Longer story:
>>>> I know that "nicer" is a subjective term, and that a lot more can be
>>> done
>>>> to improve this default PDF export. My idea was that the current
>>> defaults
>>>> we have (for the font family, for example, or the information we
>>> display in
>>>> the pdf header/footer and the style associated) are not the result of an
>>>> actual studied choice, iirc they are just defaults that were set like
>>> that
>>>> in the first version of that export and never changed. Thus, I don't see
>>>> why we couldn't slightly change these defaults (without changing the
>>>> information displayed or risking regressions) to have a slightly better
>>>> looking default PDF, while still allowing all customizations just they
>>> way
>>>> they worked before.
>>>> These modifications are not blocking nor replacing in any way the more
>>>> serious improvements that can be done on the PDF export, they're just
>>>> slightly improving the current defaults.
>>>>
>>>> Best regards,
>>>> Anca
>>>
>>>
