Your message dated Fri, 16 Aug 2013 00:33:05 +0000 with message-id <[email protected]> and subject line Bug#658999: fixed in devscripts 2.13.3 has caused the Debian Bug report #658999, regarding [uscan] mishandles upstream versions containing minus signs to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 658999: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=658999 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: devscripts Version: 2.11.3 uscan uses dpkg --compare-versions to compare upstream versions. But this command takes debian versions, which means it produces wrong results if the upstream version contains colons or minus signs. For example 3-1-1-3 > 3-1-4 (as 'upstream' is 3-1-1 vs. 3-1) To work around this attached patch compares versions after prefixing them with a fake epoch an suffixing them with a fake revision. Bernhard R. Link>From 1b0c6ac85a5e1732016fcd36b0de38e8151e75a9 Mon Sep 17 00:00:00 2001 From: "Bernhard R. Link" <[email protected]> Date: Tue, 7 Feb 2012 10:53:12 +0100 Subject: [PATCH] uscan: properly cope with colons and minus signs in upstream versions uscan uses dpkg --compare-versions to compare upstream versions. But this command takes debian versions, which means it produces wrong results if the upstream version contains colons or minus signs. To work around this compare the upstream versions with a epoch before and a revision afterwards, so that dpkg --compare-versions treats remaining colons or minus signs as part of the upstream version. For example 3-1-1-3 > 3-1-4 (as 'upstream' is 3-1-1 vs. 3-1) but 3-1-1-3-1 < 3-1-4-1 (as 'upstream' is 3-1-1-3 vs. 3-1-4) Signed-off-by: Bernhard R. Link <[email protected]> --- scripts/uscan.pl | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/uscan.pl b/scripts/uscan.pl index 3b325a5..2018172 100755 --- a/scripts/uscan.pl +++ b/scripts/uscan.pl @@ -1204,7 +1204,7 @@ EOF # Can't just use $lastversion eq $newversion, as then 0.01 and 0.1 # compare different, whereas they are treated as equal by dpkg - if (system("dpkg", "--compare-versions", "$mangled_lastversion", "eq", "$newversion") == 0) { + if (system("dpkg", "--compare-versions", "1:${mangled_lastversion}-0", "eq", "1:${newversion}-0") == 0) { if ($verbose or ($download == 0 and $report and ! $dehs)) { print $pkg_report_header; $pkg_report_header = ''; @@ -1231,7 +1231,7 @@ EOF # We use dpkg's rules to determine whether our current version # is newer or older than the remote version. if (!defined $download_version) { - if (system("dpkg", "--compare-versions", "$mangled_lastversion", "gt", "$newversion") == 0) { + if (system("dpkg", "--compare-versions", "1:${mangled_lastversion}-0", "gt", "1:${newversion}-0") == 0) { if ($verbose) { print " => remote site does not even have current version\n"; } elsif ($dehs) { -- 1.7.9
--- End Message ---
--- Begin Message ---Source: devscripts Source-Version: 2.13.3 We believe that the bug you reported is fixed in the latest version of devscripts, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. James McCoy <[email protected]> (supplier of updated devscripts package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Thu, 15 Aug 2013 20:00:57 -0400 Source: devscripts Binary: devscripts Architecture: source amd64 Version: 2.13.3 Distribution: unstable Urgency: low Maintainer: Devscripts Devel Team <[email protected]> Changed-By: James McCoy <[email protected]> Description: devscripts - scripts to make the life of a Debian Package maintainer easier Closes: 600048 610712 658999 704236 709999 711467 712166 712227 712261 712701 714599 714835 715572 Changes: devscripts (2.13.3) unstable; urgency=low . [ gregor herrmann ] * debcommit: Add the source package name to commit/tag messages. (Closes: #704236) . [ Paul Wise ] * In chdist bash completion, don't print warnings if ~/.chdist is missing * Support 'new' in the rmadison URL list. . [ James McCoy ] * dpkg-buildpackage: Use "dpkg-checkbuilddeps -A" for arch-indep builds. Bump dpkg-dev Depends to 1.16.4 accordingly. * Suppress "given/when is experimental" warnings when using Perl 5.18. * mk-build-deps: Take Build-Conflicts(-Indep) into account. (Closes: #712227) * debcommit: Use "git status --porcelain" to check for a dirty working directory. (Closes: #712166) * uscan: Add "Accept: */*" header to fix downloading from Alioth. Thanks to Dmitry Smirnov for the patch. (Closes: #712261) * transition-check: Work around Pod::Simple change which causes Perl 5.18's pod2man to fail. (Closes: #714599) * licensecheck: + Check haskell files. Thanks to Jens Petersen for the patch. + Handle differing lengths of comment leaders when autodetecting comments. (Closes: #714835) * uscan/rc-alert: Fix roff errors in man pages. Thanks to Eric S. Raymond for the patch. (Closes: #712701) * dscverify: Use ~/.gnupg/trustedkeys.gpg, if available. (Closes: #600048) . [ Chris Boot ] * bts: Fix no-mutt option. (Closes: #709999) . [ Daniel Kahn Gillmor ] * Enable OpenPGP signature verification (Closes: #610712) . [ Yaroslav Halchenko ] * licensecheck: Check .go (Go) files (Closes: #711467) * wnpp-check: Add bug URL to output and reorder columns to ease reading. (Closes: #715572) . [ Bernhard R. Link ] * uscan: properly cope with colons and minus signs in upstream versions. (Closes: #658999) . [ Phillip Hands ] * licensecheck: + allow plural: copyright notices + ignore "copyright holders" + alternative BSD-3 wording "authors" and "_any_ contributors" + ignore #defines containing (c) + fix "copyright ownership" + ignore "copyright statement" + ignore "copyright string" + ignore coyright (claim|is|in), and fix test + ignore "copyright to" Checksums-Sha1: 516c5bb5496f1ec7e0aa143ac7310121a9802f2f 1483 devscripts_2.13.3.dsc f2bb5d52f08a0b03583187bf7fb1e9f868966369 573368 devscripts_2.13.3.tar.xz af989b8067394ee26fcfe09a60e4b96b725ab6e9 854416 devscripts_2.13.3_amd64.deb Checksums-Sha256: e334049b8edf531756ad7b408dcec5f51e6e6df5f4720c02ca7ac9a93371a2fc 1483 devscripts_2.13.3.dsc 216a8a63e0a6e4d5f677ceb52e6330aa90851471fe337e87f3d053a2c1538556 573368 devscripts_2.13.3.tar.xz 8757b74d7d5390c7cad72aa77f07c68f7d8e9a6c4f08608886ecdb77e84a7519 854416 devscripts_2.13.3_amd64.deb Files: d98029fd3966299e01baa2bbed63cffc 1483 devel optional devscripts_2.13.3.dsc 1273a87daf9ff4d47f079687c2262a8c 573368 devel optional devscripts_2.13.3.tar.xz eb575ee6b000fd1874fa16638ff98190 854416 devel optional devscripts_2.13.3_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iEYEARECAAYFAlINbqwACgkQDb3UpmEybUDnRACaA4iqJu9xYzZiKrJh+da0xrzP 224AmQE70ns7dpvTyQ6eXzaypADSsFm0 =i+ZD -----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________ devscripts-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/devscripts-devel
