Your message dated Tue, 29 Oct 2013 11:18:16 -0400 with message-id <[email protected]> and subject line Re: Bug#728198: devscripts: debuild (& others) must reject debian/rules actions on unpatched source trees has caused the Debian Bug report #728198, regarding devscripts: debuild (& others) must reject debian/rules actions on unpatched source trees to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 728198: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=728198 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: devscripts Version: 2.13.4 Severity: important It does not make sense to build or clean an unpatched source tree, since the applied patches are considered strictly *part of the source package*. However, `debuild build/clean`, and probably many other tools, still allows this to happen without any warning. This is partly a fault of policy which is very loose on what is a correct state to initiate build actions from; I will file a separate bug for that too. http://www.debian.org/doc/debian-policy/ch-source.html -- Package-specific info: --- /etc/devscripts.conf --- --- ~/.devscripts --- Not present -- System Information: Debian Release: jessie/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.10-3-amd64 (SMP w/4 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages devscripts depends on: ii dpkg-dev 1.16.12 ii libc6 2.17-93 ii perl 5.18.1-4 ii python3 3.3.2-17 pn python3:any <none> Versions of packages devscripts recommends: ii at 3.1.14-1 ii curl 7.32.0-1 ii dctrl-tools 2.23 ii debian-keyring 2013.07.31 ii dput 0.9.6.4 ii equivs 2.0.9 ii fakeroot 1.18.4-2 ii gnupg 1.4.15-1.1 ii libcrypt-ssleay-perl 0.58-1+b1 ii libdistro-info-perl 0.11 ii libencode-locale-perl 1.03-1 ii libjson-perl 2.59-1 ii libparse-debcontrol-perl 2.005-4 ii libsoap-lite-perl 0.716-1 ii liburi-perl 1.60-1 ii libwww-perl 6.05-1 ii lintian 2.5.19 ii man-db 2.6.5-2 ii patch 2.7.1-3 ii patchutils 0.3.2-2 ii python3-debian 0.1.21+nmu2 ii python3-magic 1:5.14-2 ii sensible-utils 0.0.9 ii strace 4.5.20-2.3 ii unzip 6.0-9 ii wdiff 1.1.2-1 ii wget 1.14-4 ii xz-utils 5.1.1alpha+20120614-2 Versions of packages devscripts suggests: ii bsd-mailx [mailx] 8.1.2-0.20131005cvs-1 ii build-essential 11.6 pn cvs-buildpackage <none> pn devscripts-el <none> ii gnuplot 4.6.3-2 ii gpgv 1.4.15-1.1 ii heirloom-mailx [mailx] 12.5-2 ii libauthen-sasl-perl 2.1500-1 ii libfile-desktopentry-perl 0.07-1 ii libnet-smtp-ssl-perl 1.01-3 pn libterm-size-perl <none> ii libtimedate-perl 1.2000-1 ii libyaml-syck-perl 1.27-2+b1 ii mutt 1.5.21-6.4 ii openssh-client [ssh-client] 1:6.2p2-6 pn svn-buildpackage <none> ii w3m 0.5.3-11 -- no debconf information
--- End Message ---
--- Begin Message ---On Tue, Oct 29, 2013 at 12:14:16PM +0000, Ximin Luo wrote: > It does not make sense to build or clean an unpatched source tree, since the > applied patches are considered strictly *part of the source package*. However, > `debuild build/clean`, and probably many other tools, still allows this to > happen without any warning. This is not a bug in debuild. “debuild $target” should behave similar to “dpkg-buildpackage -T $target” and as stated in dpkg-buildpackage(1): 1. It prepares the build environment by setting various environment variables (see ENVIRONMENT) and calls dpkg-source --before-build (unless -T or --target has been used). … 3. If a specific target has been selected with the -T or --target option, it calls that target and stops here. Otherwise it calls fakeroot debian/rules clean to clean the build-tree (unless -nc is specified). >From this, we can see that when a specific target is provided: a) “dpkg-source --before-build” (which is what applies the patches) should not be called and b) “debian/rules $target” will be called directly and then the build will stop. The expection when a specific target is going to be run is that the working tree is in a proper state to run that target. When a target isn't specified, debuild runs dpkg-source --before-build/--after-build just like dpkg-buildpackage does. This has previously been discussed in #628481[0]. [0]: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=628481#16 Cheers, -- James
--- End Message ---
_______________________________________________ devscripts-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/devscripts-devel
