Your message dated Thu, 30 Oct 2014 18:48:40 -0500
with message-id <[email protected]>
and subject line Re: Bug#767421: debsign: clobbers shell variables instead of
using them
has caused the Debian Bug report #767421,
regarding debsign: clobbers shell variables instead of using them
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
767421: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767421
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: devscripts
Version: 2.14.7
Severity: important
File: /usr/bin/debsign
Tags: patch
I have DEBSIGN_KEYID defined for signing debian packages. Debsign
completely ignores this as it seems to clobber environment variables
with its DEFAULT_* set of values, which are undefined.
Attached patch fixes this issue.
- Adam
--- a/debsign.sh 2014-10-13 21:35:45.000000000 -0500
+++ b/debsign.sh 2014-10-30 17:17:51.058874668 -0500
@@ -256,7 +256,7 @@
# set defaults
for var in $VARS; do
- eval "$var=\$DEFAULT_$var"
+ eval $var=\${$var:-\$DEFAULT_$var}
done
else
# Run in a subshell for protection against accidental errors
@@ -264,7 +264,7 @@
eval $(
set +e
for var in $VARS; do
- eval "$var=\$DEFAULT_$var"
+ eval $var=\${$var:-\$DEFAULT_$var}
done
for file in /etc/devscripts.conf ~/.devscripts
--- End Message ---
--- Begin Message ---
On Thu, Oct 30, 2014 at 10:40:50PM +0000, Adam D. Barratt wrote:
> On Thu, 2014-10-30 at 17:26 -0500, Adam Majer wrote:
> > I have DEBSIGN_KEYID defined for signing debian packages. Debsign
> > completely ignores this as it seems to clobber environment variables
> > with its DEFAULT_* set of values, which are undefined.
>
> That's intentional. From debsign(1):
>
> The two configuration files /etc/devscripts.conf and ~/.devscripts are
> sourced in that order to set configuration variables. Command line
> options can be used to override configuration file settings.
> Environment variable settings are ignored for this purpose.
>
> Similar wording exists in most manpages from the package.
Right. Somehow I managed to grok this completely differently when I
skimmed through this section. My brain saw "Environment variable" and
"Configuration variables" and all capital convention and I thought
those were environmental variables.
May I suggest changing the heading "CONFIGURATION VARIABLES" to
"CONFIGURATION FILES" and removing the entire sentence "Environment
variable settings are ignored for this purpose." ?
- Adam
--
Adam Majer
[email protected]
--- End Message ---
_______________________________________________
devscripts-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/devscripts-devel
