Hi James, On Fri, Feb 13, 2015 at 08:11:32PM -0500, James McCoy wrote: > On Fri, Feb 13, 2015 at 01:51:48PM +0100, Andreas Tille wrote: > > I insist that the latest change in uscan / mk-origtargz is a step > > backwards since it results in errors when not needed and moreover no > > exxor occured in previous versions (namely 2.14.10 which I tested > > without any problem). I have a new occurance of this problem in > > > > Vcs-Git: git://anonscm.debian.org/debian-med/trinityrnaseq.git > > > > d/copyright says: > > > > Files-Excluded: trinity-plugins/jellyfish-*.tar.gz > > util/support_scripts/ExitTester.jar > > Butterfly/src/lib/*.jar > > Butterfly/*.jar > > Butterfly/prev_vers > > trinity-plugins/rsem*.tar.gz > > trinity-plugins/Trimmomatic* > > This listing should be fixed. However, I see that the reason it used to > "work" is that adding support for warning about unmatched patterns > caused files to be added to the "to delete" list multiple times when > there are multiple patterns which match.
I think a *warning* would be fine, but the problem is that it ends in an *error* which is not appropriate in this situation IMHO. > I'll make an adjustment to that. Thanks. > > Please make sure that the `tar --delete` command does not get any > > duplicated string even if for whatever strange reason two regexps > > might match (even if I personally do not think they do after the > > original specification. > > If by "original specification" you mean handling Files-Excluded like > shell globs, then that was flawed to start with. There's no reason to > treat Files-Excluded differently from Files. I do not understand this: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#files-field "Filename patterns in the Files field are specified using a simplified shell glob syntax." While I agree that Files-Excluded should be treated the same as Files I wonder why you assume that it should not be handled like shell globs since this is the definition. Kind regards Andreas. -- http://fam-tille.de _______________________________________________ devscripts-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/devscripts-devel
