James,
I can move it back of course.
I am actually puzzled why more is not done in debian/rules. The whole
devscripts structure seems sort of odd to me. However I was not trying
to fix that. I had a much more specific issue.
I put the test clean up in debian/rules because then one can easily
inspect the generated files between the test phase and the clean phase.
More generally I can think of several places such clean up could be put in:
1. debian/rules
2. Makefile
3. test/Makefile
4. test/test_*
The two obvious places would seem to me 1. and 4. 4. seems not to be
working. I am not quite sure why though I suspect the test script may be
exiting earlier than the cleanup. However 1. looks better to me anyway
for the reason I said. Both 2. and 3. look wrong to me. Why should
test/Makefile know about the inner workings of the tests? At least the
clean rule in debian/rules is devoted to clean up.
BTW there are several quetsions I have asked which have not been
answered. Also what are the plans for upload?
On 05/12/15 13:56, James McCoy wrote:
On Sat, Dec 05, 2015 at 12:54:37PM +0000, Nicholas Bamber wrote:
commit c065c65f77b0e1f82c470c7afbb6b43ca2ee5ec4
Author: Nicholas Bamber <[email protected]>
Date: Sat Dec 5 12:54:31 2015 +0000
move test clean up to test rule
---
debian/rules | 4 ++++
test/Makefile | 2 --
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/debian/rules b/debian/rules
index 87f9c4f..0cfb25f 100755
--- a/debian/rules
+++ b/debian/rules
@@ -11,3 +11,7 @@ ifeq ($(shell dpkg-vendor --derives-from Ubuntu && echo
ubuntu),ubuntu)
else
dh_gencontrol -- -V'vendor:Suggests='
-V'vendor:Recommends=$(UBU_SUGGESTS)'
endif
+
+override_dh_clean:
+ rm -rf test/uscan/gpg test/package_lifecycle
Why is this in debian/rules? This should be part of the normal
Makefile.
Cheers,
_______________________________________________
devscripts-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/devscripts-devel
