Package: devscripts
Version: 2.17.1
Severity: wishlist
Tags: patch

Dear Maintainer,

please consider applying the attached patch which replaces calling dpkg
--compare-versions with functionality found in Dpkg::Version (which
already is used from debchange).

Cheers,
-Hilko

>From fb8f4b6536833637c1b2f5e82664c223e00a9386 Mon Sep 17 00:00:00 2001
From: Hilko Bengen <ben...@debian.org>
Date: Fri, 3 Feb 2017 18:19:16 +0100
Subject: [PATCH] debchange.pl: Replace dpkg call with
 Dpkg::Version::compare_version

---
 scripts/debchange.pl | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/scripts/debchange.pl b/scripts/debchange.pl
index 9a36432..734b313 100755
--- a/scripts/debchange.pl
+++ b/scripts/debchange.pl
@@ -1071,8 +1071,7 @@ if (($opt_i || $opt_n || $opt_bn || $opt_qa || $opt_R || $opt_s || $opt_team ||
 	    $opt_p=1;
 	}
 
-	if (system("dpkg --compare-versions $VERSION le $NEW_VERSION" .
-		  " 2>/dev/null 1>&2")) {
+	if (version_compare($VERSION, $NEW_VERSION) == 1) {
 	    if ($opt_b or ($opt_allow_lower and $NEW_VERSION =~ /$opt_allow_lower/)) {
 		warn "$progname warning: new version ($NEW_VERSION) is less than\n" .
 		    "the current version number ($VERSION).\n";
-- 
2.1.4

_______________________________________________
devscripts-devel mailing list
devscripts-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/devscripts-devel

Reply via email to