Your message dated Fri, 7 Jul 2017 22:02:58 -0400
with message-id <[email protected]>
and subject line Re: Bug#866148: [general] Do not require POSIX style argument
order
has caused the Debian Bug report #866148,
regarding [general] Do not require POSIX style argument order
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
866148: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=866148
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: devscripts
Version: 2.17.6
Severity: wishlist
Tags: patch
User: [email protected]
Dear Maintainer,
the scripts "bts", "chdist" and "dpkg-depcheck" currently require the user
to put command-line arguments in POSIX way, i.e., option arguments
should come first and then non-option ones. As Perl's Getopt module
supports the environment variable POSIXLY_CORRECT (if it is enabled
then the POSIX order is required) I suggest we leave out the hard
coding of this order requirement out from the scripts. I
have included a patch.
Thank you,
Joona Kylmälä
-- Package-specific info:
--- /etc/devscripts.conf ---
--- ~/.devscripts ---
Not present
-- System Information:
Debian Release: buster/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages devscripts depends on:
ii dpkg-dev 1.18.24
ii libc6 2.24-12
ii libfile-homedir-perl 1.00-1
ii perl 5.24.1-4
ii python3 3.5.3-1
Versions of packages devscripts recommends:
ii apt 1.4.6
ii at 3.1.20-3
ii dctrl-tools 2.24-2+b1
ii debian-keyring 2017.05.28
ii dput 0.12.1
ii equivs 2.0.10
ii fakeroot 1.21-3.1
ii file 1:5.30-1
ii gnupg 2.1.18-8
ii libdistro-info-perl 0.15
ii libdpkg-perl 1.18.24
ii libencode-locale-perl 1.05-1
ii libgit-wrapper-perl 0.047-1
ii liblist-compare-perl 0.53-1
ii liblwp-protocol-https-perl 6.06-2
ii libsoap-lite-perl 1.20-1
ii liburi-perl 1.71-1
ii libwww-perl 6.15-1
ii licensecheck 3.0.29-1
ii lintian 2.5.51
ii man-db 2.7.6.1-2
ii patch 2.7.5-1+b2
ii patchutils 0.3.4-2
ii python3-debian 0.1.30
ii python3-magic 1:5.30-1
ii sensible-utils 0.0.9
ii strace 4.15-2
ii unzip 6.0-21
ii wdiff 1.2.2-2
ii wget 1.19.1-4
ii xz-utils 5.2.2-1.2+b1
Versions of packages devscripts suggests:
pn adequate <none>
pn autopkgtest <none>
pn bls-standalone <none>
ii build-essential 12.3
pn check-all-the-things <none>
pn cvs-buildpackage <none>
pn devscripts-el <none>
pn diffoscope <none>
pn disorderfs <none>
pn dose-extra <none>
pn duck <none>
pn faketime <none>
pn gnuplot <none>
ii gpgv 2.1.18-8
pn how-can-i-help <none>
ii libauthen-sasl-perl 2.1600-1
pn libfile-desktopentry-perl <none>
pn libnet-smtps-perl <none>
pn libterm-size-perl <none>
ii libtimedate-perl 2.3000-2
pn libyaml-syck-perl <none>
ii mailutils [mailx] 1:3.1.1-1
pn mozilla-devscripts <none>
ii mutt 1.8.3+neomutt20170609-2
ii openssh-client [ssh-client] 1:7.5p1-5
pn piuparts <none>
pn ratt <none>
pn reprotest <none>
pn svn-buildpackage <none>
pn w3m <none>
-- no debconf information
>From dbc7b25c02abcb5669d924adb162cb28a3270c41 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <[email protected]>
Date: Tue, 27 Jun 2017 18:40:13 +0000
Subject: [PATCH] Don't require POSIX style argument ordering
---
scripts/bts.pl | 2 +-
scripts/chdist.pl | 2 +-
scripts/dpkg-depcheck.pl | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/bts.pl b/scripts/bts.pl
index 2468978d..2be102ed 100755
--- a/scripts/bts.pl
+++ b/scripts/bts.pl
@@ -597,7 +597,7 @@ my $opt_ccemail = "";
my $use_default_cc = 1;
my $ccsecurity="";
-Getopt::Long::Configure(qw(gnu_compat bundling require_order));
+Getopt::Long::Configure(qw(gnu_compat bundling));
GetOptions("help|h" => \$opt_help,
"version" => \$opt_version,
"o" => \$offlinemode,
diff --git a/scripts/chdist.pl b/scripts/chdist.pl
index 832036c9..3e5ed7be 100755
--- a/scripts/chdist.pl
+++ b/scripts/chdist.pl
@@ -146,7 +146,7 @@ use File::Copy qw(cp);
use File::HomeDir;
use File::Path qw(make_path);
use File::Basename;
-use Getopt::Long qw(:config gnu_compat bundling require_order);
+use Getopt::Long qw(:config gnu_compat bundling);
use Cwd qw(abs_path cwd);
use Dpkg::Version;
use Pod::Usage;
diff --git a/scripts/dpkg-depcheck.pl b/scripts/dpkg-depcheck.pl
index 3c1ac80e..a37ae766 100755
--- a/scripts/dpkg-depcheck.pl
+++ b/scripts/dpkg-depcheck.pl
@@ -175,7 +175,7 @@ if (@ARGV and $ARGV[0] =~ /^--no-?conf$/) {
$opts{"pkgs"} = 'all';
$opts{"allpkgs"} = 0;
-Getopt::Long::Configure('bundling','require_order');
+Getopt::Long::Configure('bundling');
GetOptions("h|help" => sub { usage(); exit; },
"v|version" => sub { version(); exit; },
"a|all" => sub { $opts{"allpkgs"}=1; },
--
2.13.2
--- End Message ---
--- Begin Message ---
On Tue, Jun 27, 2017 at 06:54:52PM +0000, Joonas Kylmälä wrote:
> the scripts "bts", "chdist" and "dpkg-depcheck" currently require the user
> to put command-line arguments in POSIX way, i.e., option arguments
> should come first and then non-option ones. As Perl's Getopt module
> supports the environment variable POSIXLY_CORRECT (if it is enabled
> then the POSIX order is required) I suggest we leave out the hard
> coding of this order requirement out from the scripts. I
> have included a patch.
These particular scripts set 'require_order' because they have
structured command lines and we don't want to mix the options with the
following commands.
bts has sub-commands, some of which take options, and we don't want to
mix bts' options with those of the sub-commands.
Both chdist and dpkg-depcheck run other commands which arbitrary sets of
options, which we don't want to confuse with the options associated with
chdist/dpkg-depcheck.
When these were initially implemented, it may have been better to
require -- to separate the main script from the other commands, but it's
too late to do that now.
Therefore I'm closing this bug.
Cheers,
--
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB
--- End Message ---
_______________________________________________
devscripts-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/devscripts-devel
