Your message dated Fri, 27 Oct 2017 13:48:48 +0000
with message-id <[email protected]>
and subject line Bug#877440: fixed in devscripts 2.17.11
has caused the Debian Bug report #877440,
regarding debsign: broken bash completion
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
877440: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=877440
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: devscripts
Version: 2.17.6+deb9u1
Severity: important
Tags: patch
Hi,
As mentioned on #dd earlier, bash completion for debsign doesn't work:
the filename gets completed based on the longest prefix as usual, but
if one types e.g. "." for a ".dsc", the rest isn't completed. Looking
at the code, acceptable answers (COMPREPLY) are determined by
appending a few known suffixes to the current word. This doesn't work
once we're past the common part.
After a quick research (read: I haven't checked official documentation
for best practices, etc.), the attached patch looks reasonable to me:
the known suffixes are added as such (instead of as globs using the
current word), and results are filtered using the current word.
Below, you'll find examples based on my ~/debian-installer directory,
with differences before/after applying the patch.
================================================================================================
Before:
-------
[1] kibi@armor:~/debian-installer$ debsign debian-installer_201
debian-installer_201611XX_amd64.buildinfo
debian-installer_20170615+deb9u2.dsc
debian-installer_201611XX_amd64.changes
debian-installer_20170615+deb9u2_source.buildinfo
debian-installer_20170525.dsc
debian-installer_20170615+deb9u2_source.changes
debian-installer_20170525_source.changes debian-installer_20170615.dsc
debian-installer_20170608_amd64.buildinfo
debian-installer_20170615_source.buildinfo
debian-installer_20170608_amd64.changes
debian-installer_20170615_source.changes
debian-installer_20170608.dsc
debian-installer_20170828_amd64.buildinfo
debian-installer_20170608_source.changes
debian-installer_20170828_amd64.changes
debian-installer_20170615+deb9u2_amd64.buildinfo debian-installer_20170828.dsc
debian-installer_20170615+deb9u2_amd64.changes
debian-installer_20170828_source.changes
[2] kibi@armor:~/debian-installer$ debsign debian-installer_20170615
debian-installer_20170615+deb9u2_amd64.buildinfo
debian-installer_20170615+deb9u2_source.changes
debian-installer_20170615+deb9u2_amd64.changes debian-installer_20170615.dsc
debian-installer_20170615+deb9u2.dsc
debian-installer_20170615_source.buildinfo
debian-installer_20170615+deb9u2_source.buildinfo
debian-installer_20170615_source.changes
[3] kibi@armor:~/debian-installer$ debsign debian-installer_20170615+deb9u2
debian-installer_20170615+deb9u2_amd64.buildinfo
debian-installer_20170615+deb9u2_source.buildinfo
debian-installer_20170615+deb9u2_amd64.changes
debian-installer_20170615+deb9u2_source.changes
debian-installer_20170615+deb9u2.dsc
[4] kibi@armor:~/debian-installer$ debsign debian-installer_20170615+deb9u2.
[nothing]
[5] kibi@armor:~/debian-installer$ debsign
debian-installer_20170615+deb9u2_amd64.
[nothing]
================================================================================================
After:
------
[1] kibi@armor:~/debian-installer$ debsign debian-installer_201
debian-installer_201611XX_amd64.buildinfo
debian-installer_20170615+deb9u2.dsc
debian-installer_201611XX_amd64.changes
debian-installer_20170615+deb9u2_source.buildinfo
debian-installer_20170525.dsc
debian-installer_20170615+deb9u2_source.changes
debian-installer_20170525_source.changes debian-installer_20170615.dsc
debian-installer_20170608_amd64.buildinfo
debian-installer_20170615_source.buildinfo
debian-installer_20170608_amd64.changes
debian-installer_20170615_source.changes
debian-installer_20170608.dsc
debian-installer_20170828_amd64.buildinfo
debian-installer_20170608_source.changes
debian-installer_20170828_amd64.changes
debian-installer_20170615+deb9u2_amd64.buildinfo debian-installer_20170828.dsc
debian-installer_20170615+deb9u2_amd64.changes
debian-installer_20170828_source.changes
[2] kibi@armor:~/debian-installer$ debsign debian-installer_20170615
debian-installer_20170615+deb9u2_amd64.buildinfo
debian-installer_20170615+deb9u2_source.changes
debian-installer_20170615+deb9u2_amd64.changes debian-installer_20170615.dsc
debian-installer_20170615+deb9u2.dsc
debian-installer_20170615_source.buildinfo
debian-installer_20170615+deb9u2_source.buildinfo
debian-installer_20170615_source.changes
[3] kibi@armor:~/debian-installer$ debsign debian-installer_20170615+deb9u2
debian-installer_20170615+deb9u2_amd64.buildinfo
debian-installer_20170615+deb9u2_source.buildinfo
debian-installer_20170615+deb9u2_amd64.changes
debian-installer_20170615+deb9u2_source.changes
debian-installer_20170615+deb9u2.dsc
[4] kibi@armor:~/debian-installer$ debsign debian-installer_20170615+deb9u2.
→ completes the filename: debian-installer_20170615+deb9u2.dsc
[5a] kibi@armor:~/debian-installer$ debsign
debian-installer_20170615+deb9u2_amd64.
debian-installer_20170615+deb9u2_amd64.buildinfo
debian-installer_20170615+deb9u2_amd64.changes
[5b] kibi@armor:~/debian-installer$ debsign
debian-installer_20170615+deb9u2_amd64.c
→ completes the filename: debian-installer_20170615+deb9u2_amd64.changes
================================================================================================
Thanks for considering, for unstable and for stretch.
KiBi.
>From a8afcc778da9109d85e55ceb5fa6e380f82889ff Mon Sep 17 00:00:00 2001
From: Cyril Brulebois <[email protected]>
Date: Sun, 1 Oct 2017 21:10:26 +0200
Subject: [PATCH] debsign: Fix bash completion.
Use file extensions instead of globs.
---
debian/changelog | 4 ++++
scripts/debsign.bash_completion | 8 ++++----
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index dd2ecc74..332b60d6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -28,6 +28,10 @@ devscripts (2.17.11) UNRELEASED; urgency=medium
[ Christoph Berg ]
* origtargz: Allow invocation from subdirectory. (Closes: #702636)
+ [ Cyril Brulebois ]
+ * debsign: Fix bash completion by using file extensions instead of
+ using globs.
+
-- Chris Lamb <[email protected]> Wed, 27 Sep 2017 13:24:39 +0100
devscripts (2.17.10) unstable; urgency=medium
diff --git a/scripts/debsign.bash_completion b/scripts/debsign.bash_completion
index 21ea89e9..ebaaa7fd 100644
--- a/scripts/debsign.bash_completion
+++ b/scripts/debsign.bash_completion
@@ -19,10 +19,10 @@ _debsign()
;;
*)
COMPREPLY=( $(
- compgen -G "${cur}*.changes"
- compgen -G "${cur}*.buildinfo"
- compgen -G "${cur}*.dsc"
- compgen -G "${cur}*.commands"
+ compgen -f -X "!*.changes" -- "$cur"
+ compgen -f -X "!*.buildinfo" -- "$cur"
+ compgen -f -X "!*.dsc" -- "$cur"
+ compgen -f -X "!*.commands" -- "$cur"
compgen -W "$options" | grep "^$cur"
) )
;;
--
2.11.0
--- End Message ---
--- Begin Message ---
Source: devscripts
Source-Version: 2.17.11
We believe that the bug you reported is fixed in the latest version of
devscripts, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mattia Rizzolo <[email protected]> (supplier of updated devscripts package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 27 Oct 2017 14:52:18 +0200
Source: devscripts
Binary: devscripts
Architecture: source
Version: 2.17.11
Distribution: unstable
Urgency: medium
Maintainer: Devscripts Devel Team <[email protected]>
Changed-By: Mattia Rizzolo <[email protected]>
Description:
devscripts - scripts to make the life of a Debian Package maintainer easier
Closes: 702636 862324 871657 875861 875887 876024 877104 877440 877877 879207
879798
Changes:
devscripts (2.17.11) unstable; urgency=medium
.
[ James McCoy ]
* Remove myself from Uploaders.
.
[ Osamu Aoki ]
* debuild:
+ Support newer and long dpkg-buildpackage options --no-sign,
--unsigned-source, --unsigned-changes, -ui and --unsigned-buildinfo,
therefore bumping the dpkg-bev dependency to version to 1.18.19.
Closes: #876024
* debian/control:
+ Remov Martin Zobel-Helas, Patrick Schoenfeld and Benjamin Drung
from Uploaders after asking them.
Thanks for all your contributions!
* uscan:
+ Auto set --force-download when appropriate to retain the
previous behaviour.
+ Correct information about the OpenPGP key fingerprints. Closes: #877104
.
[ Chris Lamb ]
* reproducible-check:
+ Match name of the json file on remote server.
+ Use the restricted JSON file that hides transient issues. Closes:
#875861
+ Handle multi-architecture systems. Closes: #875887
+ Expire cache file after 1 day and base local cache name on the
remote filename.
+ Various flake8-related tidyintidying.
* debian/control:
+ Mention reproducible-check in the package long description.
* debchange:
+ Add support for preparing uploads to stable with the new --stable flag.
Closes: #871657
.
[ Christoph Berg ]
* origtargz:
+ Allow invocation from subdirectory. Closes: #702636
.
[ Cyril Brulebois ]
* debsign:
+ Fix bash completion by using file extensions instead of
using globs. Closes: #877440
.
[ Mattia Rizzolo ]
* debchange:
+ Update the manpage to mention that --bpo now targets stretch-backports,
not jessie-backports. Closes: #877877
* debian/control:
+ Annotate the build-dependencies on perl and python3-all with :any.
+ Add myself to uploaders.
+ Bump Standards-Version to 4.1.1, no changes needed.
+ Drop Testsuite:autopkgtest field, it's automatically added by
dpkg-source.
+ Promote sensible-utils from Recommends to Depends.
* debrsign:
+ Apply patch from Gilles Filippini <[email protected]> to add support for
.buildinfo files. Closes: #862324
* uscan:
+ Apply patch from Stephen Kitt <[email protected]> to support https in the
sf.net special redirector. Closes: #879207
* tests:
+ mk-origtargz: fix check with dpkg 1.19.x. Thanks to Adam Conrad
<[email protected]> for the patch. Closes: #879798
Checksums-Sha1:
164ba93d2a438bfd649136e55460756bb615333b 2592 devscripts_2.17.11.dsc
3fa85552861eed0b2fadcdc1e6d3479083921dd5 708508 devscripts_2.17.11.tar.xz
d89c012dab7bf884730730d1c9b6fef9f0e64c94 10105
devscripts_2.17.11_amd64.buildinfo
Checksums-Sha256:
f7d513add3232962d0cde457cb0b3baefed731dec83f83778ebc2704da7e7805 2592
devscripts_2.17.11.dsc
2fefafd23e1707b07c4010ca27aa708992911aa474cd33cd888375d868ddc2da 708508
devscripts_2.17.11.tar.xz
780569d50f6dda2cabb4271f3928769af899c814d2c6730f35a760876bc3487f 10105
devscripts_2.17.11_amd64.buildinfo
Files:
5724f20343384767a94609448da9e307 2592 devel optional devscripts_2.17.11.dsc
540ec2700027618abeb236aaee7817c4 708508 devel optional
devscripts_2.17.11.tar.xz
3d3a687f671d0e7cf3d6775a25651b3f 10105 devel optional
devscripts_2.17.11_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAlnzNDAACgkQCBa54Yx2
K61nQA/+JHagvHbw3p5tBxbL5hFK5rnf47cVMh/SVp1xwS/ItLh4M7qOFeCC8tUl
X9n9c/S0hWGtZ1rCYWO6SKXGSQM41CZ29++fN75E9zI/OdvqYcFXAe9RzQEK3OBb
vI5us34upEinQKILon/EzWGKoBExJ0GmGwjyT0kE0LvcBZmD2FNrXJGtzkGeUFjU
PrvX/kxHpAzoBL/BkPG5BbSQl9lmsEqqFwJRiyab5gAv1Yyc4kadFYqNBpmO8f+P
yXXZTadFQNYpRJyIJHnzO5Kxt/8VSh1zyeYTC1zB3+8ObEQLfbg9uzrZpHfrt1Cz
RoD4TVUMAZQIFvriVrBjlyPoV4lv2wxk6qCn1ls5FdJXl/iRrRxxcY04Ghzb+S6L
mbV7d3u5rkMpix/8z/j8TBcEE2eF6B7P2unaAEOYEXjDOl1YrO5gdr0P+YT/r/w+
1rdeYPUtvGD36jYt8UYEUr73bMgxnxyzcZurG2pMimLKPLsEKGiw9C3kJLJEf5oZ
Rhg+ja3rGQqauUjeW16kofGTctYwd094Nyg3czOp0rmvYP/AJrUB2skkljO1goqv
p9bsZi8LqVjrOLQ2eQSCuUMY4VO22YJAI/w+Mxo7O0EhZr1umy9hgRsy03H+AVSP
rOmY5/TJjb/pf8/bk/Inc+6Ddp5MFYMXFj4PWSsohU+XbdTJNFE=
=59EK
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
devscripts-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/devscripts-devel
