On Wed, Sep 2, 2015 at 5:32 PM, Bob Jolliffe <bobjolli...@gmail.com> wrote:
> Hi Lars > > Renaming sounds good. Just a minor clarification request/suggestion below > ... > > On 25 August 2015 at 10:31, Lars Helge Øverland <larshe...@gmail.com> > wrote: > > Hi Tran, Abyot, > > > > I propose that we rename: > > > > ProgramInstance.dateOfIncident to incidentDate; > > +1 > > > > > and > > > > Program.dateOfEnrollmentDescription > enrollmentDateDescription; > > Program.dateOfIncidentDescription > incidentDateDescription; > > If I read this correctly this is a string used as a label for the > field rather than a description. I'm not really sure this belongs in > the model anyway, but if so maybe enrollmentDateLabel and > incidentDateLabel might be more suitable. > > Agreed, label is better. Tran, lets use that since we are changing it anyway: Program.dateOfEnrollmentLabel Program.dateOfIncidentLabel
-- Mailing list: https://launchpad.net/~dhis2-devs-core Post to : dhis2-devs-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~dhis2-devs-core More help : https://help.launchpad.net/ListHelp
