Hi there, I agree this part is not great and inconsistent. Thanks for the pull requests.
I would say we should centralize this code so that we get consistency across interpretations (report table, chart, event report, event chart). I have committed a modified version of your PR here: https://github.com/dhis2/dhis2-core/commit/dcc738794325ae6d5dcf03bf7835bb551fea4b53 Let me know if this is okay. regards, Lars On Tue, Sep 27, 2016 at 1:33 PM, jhansi <[email protected]> wrote: > Hello, > > We are planning to use ‘/api/interpretations’ API in DHIS2.23 for adding > comments to charts. > > We are able to create interpretation for charts and reports but, we are > not able to add the organisationUnit to the interpretation for chart > (/api/interpretation/chart/{chartId}) unlike the interpretation for > report (/api/interpretation/reportTable/{reportId}) which accepts a > request param ‘ou’. In order to provide this functionality to > interpretation for chart API, we have added a non mandatory request param > ‘ou’ which will accept the organisation unit similar to interpretation for > report API. As mentioned, this is not a mandatory param, if it is not > provided, it will fallback to the existing functionality. > > We have sent a pull request with the above mentioned functionality to > 2.23/2.24 and master branches. Please let us know if there is any issue. > > Thanks, > Poulami/Jhansi > _______________________________________________ > Mailing list: https://launchpad.net/~dhis2-devs > Post to : [email protected] > Unsubscribe : https://launchpad.net/~dhis2-devs > More help : https://help.launchpad.net/ListHelp > -- Lars Helge Øverland Lead developer, DHIS 2 University of Oslo Skype: larshelgeoverland [email protected] http://www.dhis2.org <https://www.dhis2.org/>
_______________________________________________ Mailing list: https://launchpad.net/~dhis2-devs Post to : [email protected] Unsubscribe : https://launchpad.net/~dhis2-devs More help : https://help.launchpad.net/ListHelp
