Got it. I've created two new bug reports for these problems: https://bugs.launchpad.net/dhis2/+bug/1638551
https://bugs.launchpad.net/dhis2/+bug/1638553 On Wed, Nov 2, 2016 at 2:59 AM, Jason Pickering <[email protected] > wrote: > Hi Jim, > Not sure what happened to the image, but its not really important. > > My workaround was to basically to > > 1) Create a category option group set with type attribute (I did not have > any) > 2) Create the approval levels and approval workflow using that category > option group set through the UI. > 3) Update the dataapproval table manually > > UPDATE dataapprovallevel set categoryoptiongroupsetid = NULL; > > 4) Adjust the dataset to use the workflow I created. I had to do this with > SQL as well, as the UI did not work for me for some reason. > > After all of that, it seems to work (for those who need a work around!) > > Regards, > Jason > > > On Tue, Nov 1, 2016 at 8:07 PM, Jim Grace <[email protected]> wrote: > >> Hi Jason, >> >> Your image didn't come through; it was a broken link image. >> >> When I create or edit a dataset through the 2.25 UI, I can't find a place >> to select the workflow. (It was there in 2.23 and 2.24.) So I'm not sure >> what you mean by "added the workflow to the dataset which needs approval >> through the UI". But glad you got something working. >> >> Cheers, >> Jim >> >> >> On Tue, Nov 1, 2016 at 9:24 AM, Jason Pickering < >> [email protected]> wrote: >> >>> >>> Hi Jim, >>> >>> I think i did that actually. Have a look at these three tables. >>> >>> >>> >>> >>> After making those adjustments, and clearing the application cache, i >>> went to data approvals, but nothing appeared there, even though I had added >>> the workflow to the dataset which needs approval through the UI. However, >>> after checking in the database, it seems the UI did nothing actually. After >>> adding the workflow via SQL, it seems to work. >>> >>> Seems like a series of bugs really, but I guess I did manage to find a >>> workaround. >>> >>> Regards, >>> Jason >>> >>> >>> >>> >>> >>> On Tue, Nov 1, 2016 at 12:52 PM, Jim Grace <[email protected]> wrote: >>> >>>> Hi Jason, >>>> >>>> 1. After you patched dataapprovallevel.categoryoptiongroupsetid to >>>> NULL in the DB, subsequently could you view the approval level with no cat >>>> option combo in the edit approval level screen? >>>> >>>> 2. In order to approve a dataset, you need to create an approval >>>> workflow, assign one or more approval levels to it, and then assign the >>>> workflow to one or more datasets (the other bug I mentioned -- you may have >>>> to patch the workflowid column in the dataset record.) >>>> >>>> Cheers, >>>> Jim >>>> >>>> >>>> On Tue, Nov 1, 2016 at 8:40 AM, Jason Pickering < >>>> [email protected]> wrote: >>>> >>>>> I tried that actually but could not get any data-sets to appear in the >>>>> approvals dialog. >>>>> >>>>> I even tried to create a "Default category option group set", >>>>> containing only the "default" category option, but that did not work >>>>> either. >>>>> >>>>> Neither hack worked. >>>>> >>>>> Unfortunately, we cannot go back to 2.24 at this point, but can wait >>>>> for this to be fixed to implement the approvals. >>>>> >>>>> Thanks for looking into it. >>>>> >>>>> Regards, >>>>> Jason >>>>> >>>>> >>>>> On Tue, Nov 1, 2016 at 12:31 PM, Jim Grace <[email protected]> wrote: >>>>> >>>>>> Lars, should I create bug reports for these two 2.25 >>>>>> approvals-related problems? >>>>>> >>>>>> Jason, you could use 2.24, or you could try defining an approval >>>>>> level with a cat option group set, then find that record in the >>>>>> dataapprovallevel table and patch the categoryoptiongroupsetid column to >>>>>> null (and flush the hibernate cache.) >>>>>> >>>>>> >>>>>> On Tue, Nov 1, 2016 at 5:04 AM, Jason Pickering < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi Jim and Lars, >>>>>>> >>>>>>> Has this been solved, or is there a workaround which I can use? >>>>>>> >>>>>>> Regards, >>>>>>> Jason >>>>>>> >>>>>>> >>>>>>> On Tue, Oct 25, 2016 at 12:59 PM, Jim Grace <[email protected]> wrote: >>>>>>> >>>>>>>> I get the same results. In 2.24 and earlier I am able to save a new >>>>>>>> approval level with no category option group set. But 2.25 does not >>>>>>>> allow >>>>>>>> me to do so. >>>>>>>> >>>>>>>> Note that this is not related to the new category combination field >>>>>>>> that we will be adding to approval workflows in 2.26. This has always >>>>>>>> been >>>>>>>> an optional field for approval levels. >>>>>>>> >>>>>>>> Also in 2.25 when adding or updating a data set, there is no field >>>>>>>> for data approval workflow. It was there in 2.24. >>>>>>>> >>>>>>>> >>>>>>>> On Tue, Oct 25, 2016 at 2:03 AM, Jason Pickering < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Hi Lars, >>>>>>>>> >>>>>>>>> Here is the info you asked for. >>>>>>>>> >>>>>>>>> Version:2.25Build revision:8e07d2fBuild date:2016-10-17 06:38 >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Jason >>>>>>>>> >>>>>>>>> >>>>>>>>> On Tue, Oct 25, 2016 at 4:58 AM, Lars Helge Øverland < >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>>> Hi Jason, >>>>>>>>>> >>>>>>>>>> could you tell us the exact build date for this WAR file? >>>>>>>>>> >>>>>>>>>> Could you also try again with the latest 2.25 WAR build? >>>>>>>>>> >>>>>>>>>> We have introduced this property "categoryOptionGroupSet" in >>>>>>>>>> master, but should not be there in 2.25. >>>>>>>>>> >>>>>>>>>> regards, >>>>>>>>>> >>>>>>>>>> Lars >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Sun, Oct 23, 2016 at 12:32 AM, Jason Pickering < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> I am trying to configure a workflow for population projections >>>>>>>>>>> in 2.25. >>>>>>>>>>> First, I created a new approval worfklow called "Population" >>>>>>>>>>> with a yearly frequency. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> I then created a new approval level in the UI like this >>>>>>>>>>> >>>>>>>>>>> [image: Inline image 1] >>>>>>>>>>> >>>>>>>>>>> We are not using and category options here. In the logs I see: >>>>>>>>>>> >>>>>>>>>>> * INFO 2016-10-23 06:27:23,519 (admin) Import:Start >>>>>>>>>>> (DefaultMetadataImportService.java >>>>>>>>>>> [http-bio-127.0.0.1-8090-exec-4]) >>>>>>>>>>> * INFO 2016-10-23 06:27:23,860 (admin) >>>>>>>>>>> Import:Preheat[REFERENCE] took 0.33 seconds >>>>>>>>>>> (DefaultPreheatService.java >>>>>>>>>>> [http-bio-127.0.0.1-8090-exec-4]) >>>>>>>>>>> * INFO 2016-10-23 06:27:23,864 (admin) Import:Validation took >>>>>>>>>>> 0.00 seconds (DefaultObjectBundleValidationService.java >>>>>>>>>>> [http-bio-127.0.0.1-8090-exec-4]) >>>>>>>>>>> * INFO 2016-10-23 06:27:23,890 (admin) Creating 1 object(s) of >>>>>>>>>>> type DataApprovalWorkflow (DefaultObjectBundleService.java >>>>>>>>>>> [http-bio-127.0.0.1-8090-exec-4]) >>>>>>>>>>> * INFO 2016-10-23 06:27:24,067 (admin) Import:Commit took 0.20 >>>>>>>>>>> seconds (DefaultMetadataImportService.java >>>>>>>>>>> [http-bio-127.0.0.1-8090-exec-4]) >>>>>>>>>>> * INFO 2016-10-23 06:27:24,067 (admin) Import:Done took 0.55 >>>>>>>>>>> seconds (DefaultMetadataImportService.java >>>>>>>>>>> [http-bio-127.0.0.1-8090-exec-4]) >>>>>>>>>>> * INFO 2016-10-23 06:27:39,034 (admin) Import:Start >>>>>>>>>>> (DefaultMetadataImportService.java >>>>>>>>>>> [http-bio-127.0.0.1-8090-exec-4]) >>>>>>>>>>> * INFO 2016-10-23 06:27:40,309 (admin) >>>>>>>>>>> Import:Preheat[REFERENCE] took 1.27 seconds >>>>>>>>>>> (DefaultPreheatService.java >>>>>>>>>>> [http-bio-127.0.0.1-8090-exec-4]) >>>>>>>>>>> * INFO 2016-10-23 06:27:40,314 (admin) Import:Validation took >>>>>>>>>>> 0.00 seconds (DefaultObjectBundleValidationService.java >>>>>>>>>>> [http-bio-127.0.0.1-8090-exec-4]) >>>>>>>>>>> * INFO 2016-10-23 06:27:40,314 (admin) Import:Done took 1.28 >>>>>>>>>>> seconds (DefaultMetadataImportService.java >>>>>>>>>>> [http-bio-127.0.0.1-8090-exec-4]) >>>>>>>>>>> >>>>>>>>>>> which seems to be OK, but in the UI, I get a message that >>>>>>>>>>> creation of the approval level failed and in the JS console I see >>>>>>>>>>> >>>>>>>>>>> {"httpStatus":"Conflict","httpStatusCode":409,"status":"WARNING","message":"One >>>>>>>>>>> more more errors occurred, please see full details in import >>>>>>>>>>> report.","response":{"responseType":"ObjectReport","uid":"AD >>>>>>>>>>> Od9xfvDjH","klass":"org.hisp.dhis.dataapproval.DataApprovalL >>>>>>>>>>> evel","errorReports":[{"message":"Missing required property >>>>>>>>>>> `categoryOptionGroupSet`.","mainKlass":"org.hisp.dhis.dataap >>>>>>>>>>> proval.DataApprovalLevel","errorKlass":"org.hisp.dhis.datael >>>>>>>>>>> ement.CategoryOptionGroupSet","errorCode":"E4000"}]}} >>>>>>>>>>> >>>>>>>>>>> So, I guess the question is, how do I configure a data approval >>>>>>>>>>> workflow with no category option group? >>>>>>>>>>> >>>>>>>>>>> Regards, >>>>>>>>>>> Jason >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Jason P. Pickering >>>>>>>>>>> email: [email protected] >>>>>>>>>>> tel:+46764147049 >>>>>>>>>>> >>>>>>>>>>> _______________________________________________ >>>>>>>>>>> Mailing list: https://launchpad.net/~dhis2-devs >>>>>>>>>>> Post to : [email protected] >>>>>>>>>>> Unsubscribe : https://launchpad.net/~dhis2-devs >>>>>>>>>>> More help : https://help.launchpad.net/ListHelp >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Lars Helge Øverland >>>>>>>>>> Lead developer, DHIS 2 >>>>>>>>>> University of Oslo >>>>>>>>>> Skype: larshelgeoverland >>>>>>>>>> [email protected] >>>>>>>>>> http://www.dhis2.org <https://www.dhis2.org/> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Jason P. Pickering >>>>>>>>> email: [email protected] >>>>>>>>> tel:+46764147049 >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> Mailing list: https://launchpad.net/~dhis2-devs >>>>>>>>> Post to : [email protected] >>>>>>>>> Unsubscribe : https://launchpad.net/~dhis2-devs >>>>>>>>> More help : https://help.launchpad.net/ListHelp >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Jim Grace >>>>>>>> Core developer, DHIS 2 >>>>>>>> HISP US Inc. >>>>>>>> http://www.dhis2.org <https://www.dhis2.org/> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Jason P. Pickering >>>>>>> email: [email protected] >>>>>>> tel:+46764147049 >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Jim Grace >>>>>> Core developer, DHIS 2 >>>>>> HISP US Inc. >>>>>> http://www.dhis2.org <https://www.dhis2.org/> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Jason P. Pickering >>>>> email: [email protected] >>>>> tel:+46764147049 >>>>> >>>> >>>> >>>> >>>> -- >>>> Jim Grace >>>> Core developer, DHIS 2 >>>> HISP US Inc. >>>> http://www.dhis2.org <https://www.dhis2.org/> >>>> >>> >>> >>> >>> -- >>> Jason P. Pickering >>> email: [email protected] >>> tel:+46764147049 >>> >> >> >> >> -- >> Jim Grace >> Core developer, DHIS 2 >> HISP US Inc. >> http://www.dhis2.org <https://www.dhis2.org/> >> > > > > -- > Jason P. Pickering > email: [email protected] > tel:+46764147049 > -- Jim Grace Core developer, DHIS 2 HISP US Inc. http://www.dhis2.org <https://www.dhis2.org/>
_______________________________________________ Mailing list: https://launchpad.net/~dhis2-devs Post to : [email protected] Unsubscribe : https://launchpad.net/~dhis2-devs More help : https://help.launchpad.net/ListHelp
