On 5 Feb, Lars R. Clausen wrote:
>
> This patch provides a new line-style DOTTED, and an implementation of
> bitmapped images. Furthermore, I widened the standard DOT in linestyles a
> bit so it looks nicer, and caught a bug doing that. The image properties
> uses a new selector widgets for files, which will have to be improved. Two
> new files follow the patch: objects/standard/image.c and
> objects/standard/pixmaps/image.xpm. I also added some console output for
> errors loading libraries, since the error boxes may be closed too quickly
> to read. The postscript rendering is stolen from gdk_imlib, and can
> probably be improved. I am not a postscript guru.
The image stuff doesn't work for me. As soon as i specify a filename
and press apply it crashes. I committed it anyway, so we have some
code to discuss about.
I have put up the image stuff a long time because there are lots of
design decisions to be taken with them. I'm not 100% satisfied with
your design. Lets have some discussion. Here are some thoughts:
1. While imlib is very easy to use for the programmer it is not as easy
to use for the user. It creates very large dependencies to stuff that
not everyone has. And not everyone have imlib either. On the other hand,
having to do your own loading of images is a royal pain in the ass, so
we might have to run with it.
2. The way saving is currently done creates some problems. As only the
filename is included you need to know all files that are included in
the diagram when copying it. On the other hand, storing images in the
xml file takes a lot of place and is not exactly 'nice' as it must be
ascii encoded.
3. The image objects has a lot of options that i feel are pretty
unnessesary. One (background color) isn't even used, what i could see.
Any comments?
/ Alex
