Alex,
> Sending diff's to me is best. I like to read all patches before applying.
>
> But i'm not really sure what your gonna do here. There are basically three
> operations you wanna do on the properties window.
> * Apply the changes to the object
> * Hide the window
> * Revert to last applied state
>
> Applying should generally NOT hide the window, as that lead to an
> inefficient ui. And hiding the window on window close (from the
> windowmanager) in not good enought, not everyone uses that.
Here's my diff on app/properties.c that adds an okay button. I've
followed the order of buttons that's commonly used in gnome apps
as far as I can tell.
------------------begin properties.patch----------------------------
33a34
> static gint properties_okay(GtkWidget *canvas, gpointer data);
51c52
< button = gtk_button_new_with_label( _("Close") );
---
> button = gtk_button_new_with_label( _("OK") );
56c57
< GTK_SIGNAL_FUNC(gtk_widget_hide),
---
> GTK_SIGNAL_FUNC(properties_okay),
69a71,79
> button = gtk_button_new_with_label( _("Close") );
> GTK_WIDGET_SET_FLAGS(button, GTK_CAN_DEFAULT);
> gtk_box_pack_start(GTK_BOX(GTK_DIALOG(dialog)->action_area),
> button, TRUE, TRUE, 0);
> gtk_signal_connect_object(GTK_OBJECT (button), "clicked",
> GTK_SIGNAL_FUNC(gtk_widget_hide),
> GTK_OBJECT(dialog));
> gtk_widget_show (button);
>
85a96,103
> }
>
> static gint
> properties_okay(GtkWidget *canvas, gpointer data)
> {
> gint ret = properties_apply(canvas,data);
> gtk_widget_hide(canvas);
> return ret;
------------------end properties.patch----------------------------
-Ben
Ben Hochstedler http://www.mei.com/ GE Marquette Medical Systems
[EMAIL PROTECTED] Phone: 414-362-3317 Fax: 414-362-3389
