On Sun, 6 Feb 2000, Hans Breuer wrote:
> Hi James et. al.,
> based on tml's great work on Gimp and GTK, I've ported DIA
> to Windoze in almost one weekend.
Cool!
> There are only small changes in the original sources needed.
> The whole patch (including hand written make- and export-files)
> consist of an only 22K zip file.
>
> Most of the work were missing includes, which I expect to be
> needed on Linux, too; if you would use the same warning as
> error level.
Yeah.
> Were appicable I've replaced the some functions with their
> glib counter part (e.g.: snprintf -> g_snprintf)
There is actually an snprintf in lib/util.c that is compiled in if
configure cannot detect snprintf (HAVE_SNPRINTF), but i guess it is better
to use g_snprintf really. In fact maybe the snprintf implementation should
be removed.
> There are only two windoze specific changes:
>
> - an additional indirection is needed to access DIA's directories.
> On Unix it simply maps to the respective compile time definitions.
> On Win32 it determines the dia executable directory at runtime and
> maps the sub-directories relative to it (see dia_dirs.[c|h]).
Ok.
> - the color variables (color_black, gdk_color_black, ...) in
> lib/color.h need to be exported explicitly when compiling
> libdia.dll and to be imported from the other modules to get
> initialized properly.
The OS/2 port needed this too. I guess we're stuck with it.
> Is this patch and the availibility of DIA on Win32 interesting
> enough to be applied to CVS?
Sure thing. It's not very intrusive.
I'm checking it in right now.
/ Alex
