On Sat, 5 Feb 2000, Cyrille Chepelov (home) wrote:
> First, congrats, your code passed the "Murphy, first stage" test : it
> worked here (with -march=k6) (I didn't have the time to shake it with
> ElectricFence, though).
>
> On Sat, 5 Feb 2000, James Henstridge wrote:
>
> > I have converted the flowchart/box object over to using the properties
> > as a test case. It has reduced the code size by a fair ammount (there is
> > still a bit of dead code I haven't trimmed out yet, but it looks like it
> > cuts off around 100 lines of code). The automatically generated
> > properties dialog works pretty well, and even undo with it works
> > correctly. It doesn't seem to crash either, which is good :)
>
> Are these masses of tests (in box_[sg]et_props()) really necessary ?
> What about having struct type (ObjectType *) and field offset fields in
> PropDescription, and then let a pair of object_auto[sg]et_props()
> functions handle that automatically ? [there will probably be a need for
> macros around G_STRUCT_MEMBER to handle the access to the object's
> fields].
I'll take a look at this if i get some time free this week. I think it
would be good, and it should be done before all objects are converted to
minimize work.
/ Alex
