On Fri, 23 Feb 2001, Hans Breuer wrote:
> 2001-02-23 Kjartan Maraas <[EMAIL PROTECTED]>
>
> * */*.c: #incude <config.h> at the top.
> * */*.h: Remove include of "config.h" since it should only
> be included in .c files and at the very top for things to
> work.
>
> Thanks for breaking the win32 build. :-(
>
> Could someone (James, Alexander ?) define the policies for header
> inclusions ? The win32 stuff could be partly repaired by adding
> #include "config.h" in every file including "geometry.h" but at least
> to me this isn't not that appealing (I could even solve it by forcing
> config.h inclusion to every file on makefile level) ...
Kjartan was doing a clean up, as some files were not seeing the ENABLE_NLS
define, so even though translatable strings were being marked, they
weren't being translated.
The extent of the change is just including config.h at the top of each
file (before any other headers), and removing the includes from the
headers themselves. So the config.h defines should be visible in
the headers. Having the config.h include in the source files rather than
the headers is the recommended practice.
How exactly did this break the win32 build? (I am curious).
>
> What's the right way to go, if config.h definitions are required e.g.
> for inline functions in header files ?
James.
--
Email: [EMAIL PROTECTED]
WWW: http://www.daa.com.au/~james/
