On 08/27/2011 07:55 PM, dsimcha wrote:
Nice! A few issues, though:

Small feature request: Could the GNUMakeFile include a multilib option
that builds both 32-bit and 64-bit libs on a 64-bit system? I run
performance-critical scientific code on 64-bit Linux, and use GtkD to
plot results. If I don't need 64 bits of address space and the code uses
a lot of pointers, I sometimes compile it as 32-bit to make it more
cache efficient. I've been manually editing the make file to compile
both 32- and 64-bit binaries, but it would be nice if I didn't need to.

I'll add the option.

Why was SvgSurface.create changed to the much more verbose and
completely redundant SvgSurface.svgSurfaceCreate? Was this by accident?

Yes it was by accident, will fix.

Please recompile the documentation, as the docs at the dsource site are
outdated.

gtkD doesn't build on D2 for one trivial reason: You forgot a super call
for the Thread class you're inheriting from in glib\Spawn.d. (I tried it
with Git head DMD and druntime. Maybe it works for some reason on
2.054.) Fix: Change run() to return void instead of int and pass its
delegate to super. Starting on line 270 of Spawn.d:

It does compile with 2.054, ill look into this.

this(FILE* file, bool delegate (string) read )
{
this.file = file;
this.read = read;

version(druntime)
{
super(&run);
}
}

version(druntime)
{
public void run()
{
string line = readLine(file);
while( line !is null )
{
++lineCount;
if ( read !is null )
{
read(line);
}
line = readLine(file);
}
}
}



--
Mike Wey

Reply via email to