On Saturday, 25 April 2020 at 13:31:38 UTC, ag0aep6g wrote:

* You're casting a `MyButton` to `MyButton*` in two places. That doesn't make sense. Cast to `void*` if you want to see the class reference as a pointer.

* The text says "for() loop", but you're actually using `foreach` in the code.

* If `newButton` "lasts the lifetime of the for() loop", then better declare it in the loop, not as a field of the class.

* `return(index);` - Lose the parentheses. `return` is not a function.

* You're converting `lastButtonID` from int to string and back to int. That's some pointless back-and-forth.

Thanks for pointing all this out. I'll add these changes to my todo list.

Reply via email to