What    |Removed                     |Added
                 CC|                            |

------- Comment #4 from  2009-03-29 01:46 -------
(In reply to comment #2)
> So, uh.. submit the wrong patch?  Did I misread something important and subtle
> in the patch?

Sorry, you're right.  I screwed up this patch, my bad.  I had to backtrack and
make a copy of the original source tree after I started, so I ended up with the
wrong code (and forgot to retest after making patch.)

The way Walter ordered the code was what I had intended, heh.

(In reply to comment #3)
> Brad makes a good point, there are aux:, lpt1:, prn:, com1:, etc. But they all
> share the characteristic that the ':' is the last character. So, here's my
> patch:

Yes, and this is a much better patch than mine.  I see that you return empty
for "prn:" etc., and that spits out an invalid filename error, which is
probably the original intent of this code's structure.  I didn't realize that.



Reply via email to