http://d.puremagic.com/issues/show_bug.cgi?id=3424



--- Comment #4 from Leandro Lucarella <llu...@gmail.com> 2009-10-20 17:50:14 
PDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > Your commit, r1300, also removes some opSlice():
> > 
> > @@ -736,10 +740,4 @@
> > 
> >          /// Range primitive implementations.
> > -        ByLine!(Char, Terminator) opSlice()
> > -        {
> > -            return this;
> > -        }
> > -
> > -        /// Ditto
> >          bool empty() const
> >          {
> > 
> > 
> > Is this intended? If so, it would be nice if you could apply the changes in 
> > two
> > different commits (if they are really unrelated, as I think they are; if 
> > not,
> > please ignore this comment :).
> > 
> > I'm sorry to say this here I guess it's not the place, but I don't know of a
> > better place.
> 
> For a brief period, Walter required opSlice for foreach to work. He
> subsequently changed that, so I clean up that stuff when I get the 
> opportunity.

Ok, that comment would be an excellent commit message for a separated commit
removing the opSlice() ;)

Thanks for the clarification.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

Reply via email to