http://d.puremagic.com/issues/show_bug.cgi?id=3740


Leandro Lucarella <llu...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |llu...@gmail.com


--- Comment #3 from Leandro Lucarella <llu...@gmail.com> 2010-01-27 13:51:49 
PST ---
Thanks for the fix, but, speaking about the patch, is it a good idea to shadow
an object attribute with a local variable like this?

Index: /trunk/src/func.c
===================================================================
--- /trunk/src/func.c (revision 354)
+++ /trunk/src/func.c (revision 356)
@@ -131,8 +131,19 @@
     return;
     }
+
+    parent = sc->parent;
+    Dsymbol *parent = toParent();
+


I think it could be a little error prone, maybe it's a good idea to change the
local variable name :)

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

Reply via email to