https://issues.dlang.org/show_bug.cgi?id=21505
Dlang Bot <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |pull --- Comment #1 from Dlang Bot <[email protected]> --- @MoonlightSentinel updated dlang/dmd pull request #12053 "Fix duplicate function detection for overloads introduced by aliases" fixing this issue: - Fix 21505 - Rework duplicate function detection without mangling The previous implementation compared small parts of the function mangling to detect duplicate functions. This approach had several flaws manifesting in the referenced issue as well as other false positives for (static) members, `alias`ing into different scopes, ... . Issue 21505 was caused by the assumption that all functions visited by `overloadApply` have the same name. This doesn't hold for overloads introduced by an `alias`. A reliable mangling-based implementation would need to compare most of the mangled name while also omitting severel aspects e.g. the return type to detect `int foo()` and `void foo()`. Hence the current implementation was replaced by actually comparing the `FuncDeclaration`s because it allows for more fine grained checks (and also should save some memory allocations). https://github.com/dlang/dmd/pull/12053 --
