http://d.puremagic.com/issues/show_bug.cgi?id=9895



--- Comment #7 from IdanArye <[email protected]> 2013-04-08 14:30:50 PDT ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #3)
> > > For the moment we are (sort of) at the stage 2.
> > 
> > Oh, sorry. Had no idea about needing the `pull` keyword, or auto-closing 
> > when
> > the request is pulled. My previous contribution to Phobos was done entirely 
> > on
> > GitHub...
> > 
> > Just to be clear - the rule is still to use a single commit message for the
> > contribution, using git's history rewriting functionality to make fixes, 
> > right?
> 
> Yup, all the same. Plus this new idea of issue pre new stuff too.
> 
> I've seen cases where it the hook doesn't do closing. Could be a glitch or 
> that
> an issue was mentioned but not as "fix issue xyz" but rather simply "issue
> xyz".

I used the GitHub syntax and wrote "fix #9895". I've changed it now to "fix
issue 9895" to avoid problems...

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

Reply via email to