On Sunday, 26 February 2017 at 19:34:33 UTC, thorstein wrote:
// Reads CSV-like files with only numeric values in each column
// new_ndv replaces ndv, which is the original no-data-value
double[][]* readNumMatCsv(char[] filePath, int numHeaderLines, char[] ndv, char[] new_ndv)

* "no-data-value"?
* Returning a pointer seems dubious. I'd expect double[][] to work.
* It's not obvious to me what "Mat" means in "readNumMatCsv".
* The char[] arguments should be const if possible.
* You can probably add some attributes to the function: pure, @safe.

{ double[][]* p_numArray;

This brace style is rather uncommon.

  double[][] numArray;
  char[] line;
  string noCont = "File content not usable. Quit here.";
  string noFile = "Could not read file. Quit here.";
string nonNum = "Found a non-numeric value in data matrix. Quit here.";

Those message constants should be enums or static immutable. Personally, I'd just put the literals directly in the writeln calls, as you're not using them only once.

  Regex!char re = regex(r"(\n$)");

  { File f = File(filePath, "r");
    if((line = f.readln().dup).length > 0)

As far as I see, you're never using the line you're reading here. Does this just skip the header line? You're also not using numHeaderLines. Maybe this should loop numHeaderLines times? There's no need to assign to `line` then. Also no need to dup.

    { while (!f.eof())
// 1st replace ndv with new_ndv, 2nd remove all \n, 3rd check id size of read line >0 { if((line = replaceAll(f.readln().dup.replace(ndv, new_ndv), re, "")).length > 0)

byLineCopy may be simpler to use here than readln. For this use case, byLine (no copy) could probably work, too. But byLineCopy is less bug prone, so better start with that one.


It's still not clear to me what's the deal with ndv and new_ndv.

A line should contain at most one newline, at the end. There's a special function in std.string to remove an optional suffic: chomp. And with byLineCopy there's a parameter to omit the newline. I'd prefer both of those over regex here.


        // check if all elements of splitted line are numeric
        { foreach(i;split(line,","))

A string that's called "i" may be surprising to some.

Could probably use the range version of `split`: std.algorithm.iteration.splitter. That would avoid an allocation. But split is ok if you're more comfortable with arrays than with ranges.


          { if(isNumeric(i) == false)

if (!isNumeric(i))

            // otherwise return pointer to empty array
            { writeln(nonNum);
              return p_numArray;
          // convert characters to double
          if(split(line,",").length > 0)
          { numArray ~= to!(double[])(split(line,","));

You're executing `split(line, ",")` three times. Better do it just once and save the result in a (const) variable.

Instead of checking beforehand if all values are numeric, you can also just let to!(double[]) fail, and catch the exception if you want.

If I read it right, the `.length > 0` check means that blank lines are allowed at this point, right? Seems inconsistent to forbid a blank leading line but allow them later on.

      // pass reference to pointer
      p_numArray = &numArray;

No, no, no. This is a pointer to a local variable and later you return it. That's invalid, undefined behavior. Don't do it. Just return numArray itself. As expected, you don't need to return a pointer, just double[][] is fine.

      // first line empty -> return pointer to empty array
    } else { writeln(noCont); }
    // file could not be find
  } else { writeln(noFile); }

Instead of the nested `if`s style, you could reverse the conditions and return early, or maybe throw an Exception:

if (/* ... no file ... */)
    return [];
if (/* ... no content ... */)
    return [];
/* ... rest of the code ... */

That saves some indentation levels, and makes the purpose of those checks more obvious.

  return p_numArray;

Reply via email to