On Sunday, 23 February 2020 at 12:28:41 UTC, mark wrote:
On Sunday, 23 February 2020 at 09:35:30 UTC, Jacob Carlborg
wrote:
On 2020-02-23 10:03, mark wrote:
Then this would not only help dscanner, but also make it
clear to programmers that the argument could be modified.
It's not necessary for dscanner. It should look at the
signature of `getKeyval` to see that it takes an argument by
`ref`.
Just realised that the arg is 'out' not 'ref'; don't know if
that makes a difference to dscanner. Anyway, I've made a bug
report: https://github.com/dlang-community/D-Scanner/issues/793
This like
https://github.com/dlang-community/D-Scanner/issues/366 or
https://github.com/dlang-community/D-Scanner/issues/298, so a
false positive due to limlitations.
D-Scanner:
- only works at the module level (i.e cant see declaration from
an import) ;
- does not perform regular semantic (even not the ones done for
DCD) ;
People who care should just start developing a new linter based
on DMD as a library.
It's pretty clear (IMO) that these problems will never be fixed.
