On 28.12.2012 11:48, Era Scarecrow wrote:
On Thursday, 27 December 2012 at 10:16:51 UTC, Dmitry Olshansky wrote:
IRC Era Scarecrow did an amazing job on it that covered a lot of
enhancements including small string optimization, appending, slicing etc.
I recall reviewing his code and it was a Phobos pull once but then it
pulled out (for further enhancement? dunno). So definitely suggest you
two to get in touch.
I'm glad for the praise... :)
Perhaps it seems silly, however I pulled it not because I needed to
enhance it, but because it had trouble merging with other pulls. I
looked at the error(s) and it was something like '13 white spaces
mismatches'... How do you fix 13 white spaces? They're white space
because you can't see them :P Had it been lines of code you can
intelligently re-order or adjust them, but white spaces?? Sheesh...
Maybe being lazy but it was a headache trying to figure out the diff
patch and how to fix it, so haven't tried too hard on it yet. If someone
happens across that I'll give it another go and see if there's any other
fixes/enhancements I can throw on it; Maybe get it in before the next
release.
So the code was complete and working and the only problem was doing the
pull on github?
If so would you mind me trying to do that in your place? It seems worth
spending some time on to get all those improvements in.
Is the latest version this one: https://github.com/rtcvb32/phobos ?
