On 10/24/14 9:08 AM, "Marc =?UTF-8?B?U2Now7x0eiI=?= <[email protected]>"
wrote:
On Friday, 24 October 2014 at 12:45:21 UTC, Steven Schveighoffer wrote:
On 10/23/14 3:31 PM, Walter Bright wrote:
On 10/23/2014 11:40 AM, Daniel Murphy wrote:
"Steven Schveighoffer" wrote in message
news:[email protected]...
I think there is a problem though. What if you leave your debug in by
accident? Now your pure code isn't so pure, and you have no idea.
What if you leave any other form of debug code enabled by accident?
The answer
is to use version control, and make a quick pass over changes before
you commit.
Version control has been successful at eliminating such mistakes in my
experience with github.
On your own 1-person projects, or just with 2+ reviewers for every
commit?
In my experience, source control does not stop me from committing
debug code by accident.
Seriously, the idea of "just avoid committing mistakes" or "just use x
version control system" is not a very palatable answer.
I usually use `git add -p` to review my changes before I commit them.
But this doesn't prevent anything from slipping through by accident from
time to time.
Maybe a hook could reject lines that contain `debug\s*=`? Or are you
thinking about a manual review of every commit before each release?
My proposal is to have the compiler reject such code unless one of the
debugging switches is present on the command line. If you aren't
debugging, don't compile code that is marked as "only compile during
debugging." I don't think it's that complex or controversial.
-Steve
