On 2/26/15 2:42 PM, Brian Schott wrote:
On Thursday, 26 February 2015 at 21:50:56 UTC, Andrei Alexandrescu wrote:
http://wiki.dlang.org/DIP74 got to reviewable form. Please destroy and
discuss.
Thanks,
Andrei
"This is important because it limits what reference counted types." -
I'm not sure what this means.
"The methods may or may not be final or inherited." - Should this be
"final or virtual"?
"Any attributes are allowed on these methods." - I'm going to have to
write a static analysis warning for marking these "const".
"Call is inserted only if the reference is not null" - Should this be
"Call is executed only if the reference is not null"?
"</tt>opRelease</tt>" - Some markup escaped into the wild!
"The same is achievable with RCOs by means of @disable opAddRef();" -
Suggestion: add some text stating that opRelease() must still be present
and implemented.
"Attention must be paid to annotate with return all functions that
return references to owned data" -> "Attention must be paid to annotate
all functions that return references to owned data with `return`"
Excellent notes, of which two important ones. Addressed - reload
http://wiki.dlang.org/DIP74 - thanks! -- Andrei
