On Thursday, 16 April 2015 at 06:02:19 UTC, Andrei Alexandrescu wrote:
1. Challenging Walter on anything and everything seems to have become a rite of passage in our community. Some of the reviews of his code are the most petty and meaningless I've seen in my career, bar none. It doesn't help that he doesn't budge on some of the petty issues, thus a vicious circle gets created. In a recent review, after his code had been pecked within an inch of its death, it took me minutes to find two bugs that nobody had the eyes for in spite of every token of his code having been scrutinized.

It has to be said that Walter's recent work on Phobos has wide appeal, is highly interesting (who doesn't like generic algorithms?) and relatively easy to review (requires no domain-specific knowledge apart from advanced D, perhaps some Unicode). In my experience, similarly themed PRs by other authors receive a similar amount of scrutiny. I'm hesitant to believe Walter's work is being heavily scrutinized just because it's Walter.

Reply via email to