On 29/07/2015 4:23 a.m., Etienne Cimon wrote:
On Tuesday, 28 July 2015 at 15:55:04 UTC, Brad Anderson wrote:
On Tuesday, 28 July 2015 at 15:07:46 UTC, Rikki Cattermole wrote:
On 29/07/2015 2:07 a.m., Atila Neves wrote:
Start of the two week process, folks.
Code: https://github.com/s-ludwig/std_data_json
Docs: http://s-ludwig.github.io/std_data_json/
Atila
Right now, my view is no.
Just a reminder that this is the review thread, not the vote thread
(in case anyone reading got confused).
Unless there is some sort of proof that it will work with allocators.
I have used the code from vibe.d days so its not an issue of how well
it works nor nit picky. Just can I pass it an allocator (optionally)
and have it use that for all memory usage?
After all, I really would rather be able to deallocate all memory
allocated during a request then you know, rely on the GC.
That's a good point. This is the perfect opportunity to hammer out how
allocators are going to be integrated into other parts of Phobos.
From what I see from std.allocator, there's no Allocator interface? I
think this would require changing the type to `struct
JSONValue(Allocator)`, unless we see an actual interface implemented in
phobos.
There is one. IAllocator.
I use it throughout std.experimental.image. Unfortunately site is down
atm so can't link docs *grumbles*.
Btw even if an allocator is a struct, there is a type to wrap it up in a
class.