On 02/28/2017 01:07 AM, Vladimir Panteleev wrote:
On Sunday, 26 February 2017 at 14:38:03 UTC, Seb wrote:
1) Commit squashing
Reminder: please only do this only when it makes sense to (one commit
with significant changes followed by fixup commits that have no
significance on their own).
This would be the overwhelmingly frequent case. Please reach to squash
commits as the default, unless there is a special case. Thanks.
If the PR already has multiple commits split
into logical changes, don't squash as it makes bisecting and inspecting
history more difficult. If in doubt, do a regular merge.
This indicates a problem with the PR more often than not. Good PRs focus
on one issue and one issue only.
Of course there would be exceptions. Rules are not a substitute for
judgment.
Thanks,
Andrei
