On Monday, 11 December 2017 at 23:24:02 UTC, Ali Çehreli wrote:
Since I don't have access to Windows, OS X, etc. systems nor
have I expertise in them, I don't trust myself to write
core.thread tests for anything but Posix.
What to do for non-Posix systems? I'm tempted to wrap the
entire test code with version(Posix) but it will give the wrong
impression that the code passes for all other systems as well.
For example, inside
druntime/test/thread/src/attach_detach.d I can do this:
version (Posix) {
// Real test ...
} else {
void main() {} // Deceptive code
}
How can I seek testers for a pull request that I'm ready to
post? Post PR, hopefully get merged, and then open issues for
platforms that don't have those tests?
It would be easier if test/thread/Makefile had a way of running
platform-specific tests. Yes, probably I'm volunteering but
again, I couldn't do much without other platforms.
I have a feeling our automated test harness already has such
machines. If so, where are they? :)
Ali
Ali, you haven't made a PR to a dlang repository before, so you
weren't approved for the auto-tester. I just approved you and in
the future all PRs will trigger builds on all build hosts of the
auto-tester:
https://auto-tester.puremagic.com/hosts/
For an example, have a look here:
https://auto-tester.puremagic.com/pull-history.ghtml?projectid=1&repoid=1&pullid=7420
How can I seek testers for a pull request that I'm ready to
post? Post PR, hopefully get merged, and then open issues for
platforms that don't have those tests?
It's a very common practice for contributors to use the
auto-tester to test on other platforms.
As there aren't many core D devs who use Windows, you will
probably have a hard time to seek testers.
