On 1/5/2018 6:26 AM, Adam D. Ruppe wrote:
For my projects, even if a PR isn't perfect, unless it is just plain bad or goes
in a direction I strongly disagree with, I'll merge it anyway pretty quickly and
just fix up the bits I don't like later myself.
So if something is OK but not great.... don't close it, merge it! Just fix it up
after and leave a note for the original PR author showing your fixup commit so
they can learn from it next time.
The compiler is far too complex for that. It increases the technical debt.
I have pulled many PRs like that, and they've just resulted in regressions and
even more work for me to do.
