On Sunday, January 22, 2012 19:55:21 Walter Bright wrote: > On 1/22/2012 7:47 PM, Jonathan M Davis wrote: > > Being able to remove all of the stuff like `useWfuncs` would definitely > > allow us to clean up the Windows-related code in Phobos. Having to > > worry about it has definitely increased the complexity of the Windows > > API code in Phobos. > I wrote much of that code, and it did not make the code terribly dirty or > gross or excessively complex. It's a minor detail. The main issue, as far > as I'm concerned, is the existing code never gets tested on Win95 anymore, > so we don't know if it works.
It's not horrible, but it does complicate the code. I know that it's caused some issues for the folks adding to std.windows.registry. And it has to be maintained as other changes are made. For instance, I'd like to go in and make std.file support string types of wchar and dchar. But toMBSz doesn't support anything other than strings of char, so I'm going to have to go and make toMBSz support other string types, and all for platforms that are more or less dead. If we got rid of useWfuncs, then that's not a problem anymore, but we can't do that as long as we try and support pre-Win2K. - Jonathan M Davis
