Hi Alex,

Please reply to the mailing list, so others can follow the conversation
too.

On Sat, Apr 06, 2024 at 12:05:21PM +0200, a...@dismail.de wrote:

The convention in dillorc is to set the defaults in comments

Noted. For some reason I assumed its 'uncomment to enable'.

Wouldn't this be simpler?

if (prefs.scroll_switches_tabs_reverse)
    dir = -dir;

That does look simpler. I admit my beginner coding skills :)

Check PR #123 [1,2], I added you as author based on your email and name.

[1]: https://github.com/dillo-browser/dillo/pull/123
[2]: 
https://patch-diff.githubusercontent.com/raw/dillo-browser/dillo/pull/123.patch


So, regarding the idea of a 'new tab page', here is a proof of concept.
It just opens bookmarks on a new tab right now, but if you agree this
is worth persuing, I can try to work on a preference to set this to
any url specified in dillorc.

--- uicmd.cc Thu Apr  4 20:56:39 2024
+++ uicmd.cc Sat Apr  6 11:58:09 2024
@@ -775,6 +775,8 @@
      a_UIcmd_set_location_text(new_bw, URL_STR(url));
      BW2UI(new_bw)->focus_main();
   } else {
+      DilloUrl *url = a_Url_new("dpi:/bm/", NULL);
+      a_Nav_push(new_bw, url, NULL);
      BW2UI(new_bw)->focus_location();
      a_UIcmd_set_buttons_sens(new_bw);
   }


Thanks. I think is a useful feature, but we should allow the current
behavior to be kept as it is. In particular, it should be possible to
hit Ctrl-T and begin writing a new URL right away, without loading any
page.

As it will require some though, I will postpone this after 3.1.0. Feel
free to work on it in the meanwhile if you are interested :-)

Best,
Rodrigo.
_______________________________________________
Dillo-dev mailing list -- dillo-dev@mailman3.com
To unsubscribe send an email to dillo-dev-le...@mailman3.com

Reply via email to