On Wed, 28 Mar 2018, Jani Nikula <jani.nik...@intel.com> wrote: > There have been issues with git 2.7 in the past. Require 2.8 or later > for starters. > > Signed-off-by: Jani Nikula <jani.nik...@intel.com>
Pushed with Daniel's IRC rb, overriding his patch [1]. BR, Jani. [1] 20180328121718.25389-1-daniel.vetter@ffwll.ch">http://mid.mail-archive.com/20180328121718.25389-1-daniel.vetter@ffwll.ch > > --- > > I'm not sure what the required version should really be, and how > obnoxious is it to check every time. sort -VC seems to be the neatest > way to do version checks though. > --- > dim | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/dim b/dim > index 9fa6d9cd855b..e319a629b13f 100755 > --- a/dim > +++ b/dim > @@ -364,6 +364,15 @@ function git_committer_email > echo $committer_email > } > > +function git_version_check > +{ > + local min_version="git version 2.8" > + > + if ! echo -e "$min_version\n$(git version)" | sort -VC; then > + echo "WARNING: recommended minimum $min_version, you have $(git > version)" > + fi > +} > + > # get message id from file > # $1 = file > message_get_id () > @@ -2210,6 +2219,7 @@ function dim_usage > > # occasional check for dim updates > check_for_updates > +git_version_check > > # > # Command line options. -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
