On Tue, Aug 28, 2018 at 8:04 PM, Lucas De Marchi <[email protected]> wrote: > On Tue, Aug 28, 2018 at 10:24 AM Daniel Vetter <[email protected]> wrote: >> >> This gives us neat little CI integration. No more "you have a >> different version of shellcheck" - we just pick the one everyone can >> run with docker. Also, no more "oops, forgot to run make check", that >> is, if we adopt a merge request based flow. >> >> Even without this this is useful, since if you do a fork and test >> there, gitlab CI will run stuff for you. Example: >> >> https://gitlab.freedesktop.org/danvet/maintainer-tools/blob/master/.gitlab-ci.yml >> >> Observe the awesome green checkmark in the top-left corner! >> >> Signed-off-by: Daniel Vetter <[email protected]> >> --- >> .gitlab-ci.yml | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> create mode 100644 .gitlab-ci.yml >> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml >> new file mode 100644 >> index 000000000000..a5b7cc9dcb66 >> --- /dev/null >> +++ b/.gitlab-ci.yml >> @@ -0,0 +1,9 @@ >> +image: fedora:latest >> + >> +before_script: >> + - dnf install -y ShellCheck python2-docutils python2-sphinx make > > Do you plan to add a "fedora-drm" image to docker hub so this doesn't > need to be installed on every run? > Could we rather default to python3 or is it broken for our docs? "make > html" works for me with python3 using sphinx 1.7.5 on Fedora 28.
Ah, I just picked the first one. I'll retest with python3. Wrt docker image: We'll probably need to do that for igt and everything else. For maintainer-tools imo the additioinal effort isn't worth it. fedora:latest at least auto-upgrades :-) >> + >> +check: >> + stage: build >> + script: >> + - make check > > Regardless of the comments above: > > Reviewed-by: Lucas De Marchi <[email protected]> Thanks, Daniel > >> \ No newline at end of file >> -- >> 2.18.0 >> >> _______________________________________________ >> dim-tools mailing list >> [email protected] >> https://lists.freedesktop.org/mailman/listinfo/dim-tools > > > > -- > Lucas De Marchi -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dim-tools mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dim-tools
