In dim line 976:
        for patch in $dir/*; do
                     ^-- SC2231: Quote expansions in this for loop glob to 
prevent wordsplitting, e.g. "$dir"/*.txt .

Apparently the shellcheck I have is newer than the one we use for
build testing on gitlab.

Signed-off-by: Daniel Vetter <[email protected]>
---
 dim | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dim b/dim
index 369ae0846b81..70939ff9abee 100755
--- a/dim
+++ b/dim
@@ -973,7 +973,7 @@ function dim_apply_branch
        cat > $file
        git mailsplit -b -o$dir $file > /dev/null
 
-       for patch in $dir/*; do
+       for patch in "$dir"/*; do
                if ! apply_patch $patch "$@"; then
                        rv=1
                fi
-- 
2.20.0.rc1

_______________________________________________
dim-tools mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dim-tools

Reply via email to